fix: version validation

[jhellar]

Description

publishing master fails: https://circleci.com/gh/aerogear/aerogear-js-sdk/2076?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

This fixes script that validates versions.

[darahayes]

Nice, the original logic here is pretty hacky. Another option would be to assume node is always available and do something similar to version=$(PACKAGE=$PACKAGE node -e 'console.log(require(process.env.package)).version')

The syntax probably has issues but I'm sure you get the idea!

[wtrocki]

For maintenance over the future we can simply use node.js codebase instead of bash so it will be easier to track issues and test it.

[jhellar]

@darahayes I came up with something like this version=$(package=$package node -e 'console.log(require(\'./packages/\' + process.env.package.replace(\'@aerogear/\', \'\') + \'/package.json\').version)') - which looks quite ugly, the packages are not yet published&installed, so I was not able to use require(process.env.package).

@wtrocki do you mean rewriting all the bash scripts to js? would it be ok to create just github issue for it for now?

[wtrocki]

@jhellar yes. Do not get that we need to rewrite those, but we can practically have some simple mixed bash/node scripts for certain tasks. This is executed in node.js environment so we can assume that node is installed. It will be also easy to reuse this as we can publish all release scripts as package. Now I'm replicating those across 9 different repositories. Any custom release cases can be nicely coded in node.

[darahayes]

For maintenance over the future we can simply use node.js codebase instead of bash so it will be easier to track issues and test it.

It will be also easy to reuse this as we can publish all release scripts as package.

On these two points: I am +10000 on solving the problem we have with duplication of release/build/deployment tooling across repos. However I think we should not jump to the immediate conclusion that the solution is a package. I think this is something we could spike or at least have a discussion about to explore our options.

[wtrocki]

I meant to have helpers package for validating versions and all other stuff that is hard in bash. We can still have bash scripts for the rest.