New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various updates #50

Merged
merged 5 commits into from Jul 31, 2013

Conversation

Projects
None yet
3 participants
@matzew
Member

matzew commented Jul 30, 2013

The three below JIRAs are related to each other:

This PR addresses them.

@kborchers

View changes

Show outdated Hide outdated src/unified-push/aerogear.unifiedpush.js
@kborchers

View changes

Show outdated Hide outdated src/unified-push/aerogear.unifiedpush.js
@kborchers

View changes

Show outdated Hide outdated src/unified-push/aerogear.unifiedpush.js
@kborchers

View changes

Show outdated Hide outdated src/unified-push/aerogear.unifiedpush.js
@kborchers

View changes

Show outdated Hide outdated src/unified-push/aerogear.unifiedpush.js
@kborchers

View changes

Show outdated Hide outdated src/unified-push/aerogear.unifiedpush.js
@kborchers

View changes

Show outdated Hide outdated src/unified-push/aerogear.unifiedpush.js
@kborchers

View changes

Show outdated Hide outdated src/unified-push/aerogear.unifiedpush.js
@matzew

This comment has been minimized.

Show comment
Hide comment
@matzew

matzew Jul 30, 2013

Member

@kborchers @lholmquist thanks for the feedback.
I have addressed that in another commit

Member

matzew commented Jul 30, 2013

@kborchers @lholmquist thanks for the feedback.
I have addressed that in another commit

@kborchers

View changes

Show outdated Hide outdated src/unified-push/aerogear.unifiedpush.js
@kborchers

View changes

Show outdated Hide outdated src/unified-push/aerogear.unifiedpush.js
@kborchers

View changes

Show outdated Hide outdated src/unified-push/aerogear.unifiedpush.js
@kborchers

This comment has been minimized.

Show comment
Hide comment
@kborchers

kborchers Jul 30, 2013

Contributor

Let's not merge this until after https://issues.jboss.org/browse/AGPUSH-229 and the last couple of issues are addressed

Contributor

kborchers commented Jul 30, 2013

Let's not merge this until after https://issues.jboss.org/browse/AGPUSH-229 and the last couple of issues are addressed

@matzew

This comment has been minimized.

Show comment
Hide comment
@matzew

matzew Jul 31, 2013

Member

@kborchers that JIRA has been solved on doc/server side (see PRs)

Member

matzew commented Jul 31, 2013

@kborchers that JIRA has been solved on doc/server side (see PRs)

@kborchers

This comment has been minimized.

Show comment
Hide comment
@kborchers
Contributor

kborchers commented Jul 31, 2013

@matzew

This comment has been minimized.

Show comment
Hide comment
@matzew
Member

matzew commented Jul 31, 2013

@kborchers done

@kborchers kborchers merged commit 6a89c9b into aerogear:Notifier Jul 31, 2013

@kborchers

This comment has been minimized.

Show comment
Hide comment
@kborchers

kborchers Jul 31, 2013

Contributor

Thanks! Landed in 030e5cd

Contributor

kborchers commented Jul 31, 2013

Thanks! Landed in 030e5cd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment