Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in CRUDService and Knex Query Mapper #2095

Merged
merged 2 commits into from Sep 21, 2020

Conversation

craicoverflow
Copy link

@craicoverflow craicoverflow commented Sep 21, 2020

  • 5143fb6 - TypeError: Cannot read property 'page' of undefined error is thrown when no findBy#args argument is null or undefined.

  • d10e918 fixes an error where it was not possible to perform a where x is/not null query in the Knex data provider. This is already possible in the Mongo Data Provider.

All fixes accompanied by a unit test

@craicoverflow craicoverflow requested review from wtrocki and machi1990 Sep 21, 2020
@craicoverflow craicoverflow merged commit 1800fec into aerogear:master Sep 21, 2020
@craicoverflow craicoverflow deleted the fixes-to-crud branch Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants