Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove empty resolver creation in plugin #2122

Merged
merged 2 commits into from Sep 24, 2020

Conversation

craicoverflow
Copy link

@craicoverflow craicoverflow commented Sep 24, 2020

Fixes #2117

The DataSyncPlugin was creating empty root Query, Mutation and Subscription resolver objects.

@craicoverflow craicoverflow changed the title Add schema must haves remove empty resolver creation in plugin Sep 24, 2020
@@ -1,5 +1,5 @@
import yargs from 'yargs';
import * as chalk from 'chalk';
Copy link
Author

@craicoverflow craicoverflow Sep 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@machi1990 I know that you changed this back, but I was getting a build error:

Unsafe call of an any typed value. Any reason the import alias is preferred here?

Copy link
Contributor

@machi1990 machi1990 Sep 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was changed in #2026 since the printSchema command was not working.

Copy link
Contributor

@machi1990 machi1990 Sep 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've accepted the change without re-verifying this part as it seems unrelated. I trust you on that and the command should work.

Copy link
Author

@craicoverflow craicoverflow Sep 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay it is not working for me now - what I will do is disable that line with eslint

@craicoverflow craicoverflow marked this pull request as ready for review Sep 24, 2020
@craicoverflow craicoverflow requested review from wtrocki and machi1990 Sep 24, 2020
@craicoverflow craicoverflow merged commit ec7bed7 into aerogear:master Sep 24, 2020
@craicoverflow craicoverflow deleted the add-schema-must-haves branch Sep 24, 2020
@craicoverflow craicoverflow added the bug Something isn't working label Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Error: "Mutation" defined in resolvers, but not in schema]
2 participants