New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AEROGEAR-3075 Group apps into single one #65
Conversation
I'd recommend to merge #64 first, because testing APBs on Wendy is pretty unstable. |
👁️ |
|
||
- name: delete configmap template file | ||
file: path=/tmp/configmap.yaml state=absent | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@psturc what's this block doing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, got it. we were missing the config map on ephemeral installations. Thanks for fixing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is just a copy-pasta of provision-app-metrics.yml file except PV and PVC configuration. It was needed because the tests were failing on Wendy if Postgres was deployed with persistent volume attached to it.
I've only updated it, because some changes from provision-app-metrics.yml
were apparently not applied to this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@psturc when I compare the ephemeral yml with the other yml, I see 2 diffs that could be missed: Could you please have a look? |
@aliok good catch, thanks. I've fixed the wrong labels and removed "ephemeral" role. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
verified locally.
@psturc I wonder if there's a way to control which route/url shows up as the main one in the overview screen when the 'application' is collapsed. |
@psturc We can set the following annotation on each route
The makes all the routes show up in the UI There is also a scoring system for deciding which route to show, but in this case showing all routes is probably best. |
@david-martin that's brilliant, thanks for finding that out! Annotations added in d91fef6 |
https://issues.jboss.org/browse/AEROGEAR-3075
While putting all services under single group could make the project more clear, it also make an app a bit poorly arranged due to hiding routes to some services (in this case Grafana & Prometheus route):
The routes are visible once the row is clicked on (expanded)
IMO this is not a big issue, but I'm rather mentioning it.