Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove (broken) support for floating point user keys #158

Closed
jhecking opened this issue Dec 15, 2016 · 0 comments
Closed

Remove (broken) support for floating point user keys #158

jhecking opened this issue Dec 15, 2016 · 0 comments
Assignees
Labels
Milestone

Comments

@jhecking
Copy link
Contributor

The client currently accepts float values (as well as integers, strings and Buffers) as record keys. However float values are being truncated to integers before the key digest is calculated! Therefore float values are basically useless as record keys since e.g. the key 3.14159 and the key 3 would both generate the same digest and therefore read/write the same record.

Since the server officially only supports integers, strings and byte arrays (Buffers) as record keys, the client should reject floating point record keys.

@jhecking jhecking added the bug label Dec 15, 2016
@jhecking jhecking self-assigned this Dec 15, 2016
@jhecking jhecking added this to the v2.4.4 milestone Dec 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant