New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes on things #41

Merged
merged 1 commit into from Oct 23, 2017

Conversation

Projects
None yet
2 participants
@linuxgemini
Contributor

linuxgemini commented Oct 22, 2017

  • Fixed HTTPS detection on viewer.phtml.
  • Fixed Stylesheet location where it was relying on site root.

One request for the wiki:

If the server has HTTPS redirection (with the .htaccess file on the site root), this gets turned off on the imageserve folder. I am suggesting that these lines should be added to the public/.htaccess file:

# old code above
RewriteEngine On

RewriteCond %{HTTPS} off
RewriteRule ^(.*)$ https://%{HTTP_HOST}%{REQUEST_URI} [L,R=301]

RewriteRule  ^/?$                           viewer.php                      [L]
# old code below

Edited: Markdown failure on multi-line code.
Edited again and again: General look and markdown fixes.

Fixes on things
Fixed HTTPS detection on viewer.phtml
Fixed Stylesheet location where it was relying on site root
@aerouk

This comment has been minimized.

Owner

aerouk commented Oct 23, 2017

Thank you for suggesting these changes.

I'm going to go ahead and merge this, but I'm still a bit lost on your reasoning for forcing SSL for the whole of the app. Granted, it should be enabled for the upload.php script but I'm not willing to force it anywhere else. If users wish to enable SSL from the app root, then they can make the changes in their installation.

Once again, thanks for contributing 😄

@aerouk aerouk merged commit ed97393 into aerouk:master Oct 23, 2017

1 check passed

continuous-integration/styleci/pr The StyleCI analysis has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment