AEX-2: Issues list

[davidyuk]

Wallet methods

• what is return value of aepp.get.address method? extracted to AEX-2: Make aepp.get.address method simplier #46
• in what format tx should be passed to aepp.request.sign method? I see several options: hex string, an array of bytes, tx_.. string, the current explanation is too ambiguous extracted to AEX-2: Explain how transaction encoded to string #65
• in what format tx returned from aepp.request.sign method? extracted to AEX-2: Explain how transaction encoded to string #65
• for what reason aepp.request.sign and other methods should return id received in arguments?

Aepp methods

• what is return value of wallet.get.network method? extracted to AEX-2: In which case may be needed to update network from aepp? #50
• how aepp can use a list of connected account returned from wallet.update.address if it can't switch between them? We either should drop it or add a method for account switching. extracted to AEX-2: How aepp can use a list of accounts returned from wallet.update.address? #47
• can wallet.update.address be simplified by extracting of getting a list of connected accounts into a separate method? extracted to AEX-2: Make account retrieving simpler #48
• wallet.update.address method should explain parameters explicitly, not only by providing an example extracted to Should be possible to explain AEXs in examples without explanations that cover them completely? #45
• for what reason in which cases wallet.broadcast.tx and wallet.verify.tx methods are necessary? extracted to AEX-2: In which cases wallet.broadcast.tx method are necessary? #63

Common issues

• add errors that can be thrown by method to explanation of every method remove errors explanations from wallet.broadcast.tx, wallet.verify.tx for consistency with other methods extracted to AEX-2: Consistent explanations of exceptions that can be thrown by each method #66
• how aepp.update.network and wallet.get.network methods are supposed to work? extracted to AEX-2: In which case may be needed to update network from aepp? #50

[shekhar-shubhendu]

as these issues deal with syntactic changes and not the core functionality provided by the proposal, therefore, these will be added either in this sprint or the next. thanks for the contribution.

for some of the issues stated I suggest you to please re-read the proposal.

[davidyuk]

yes, but it can lead to breaking changes in AEX-2

[shekhar-shubhendu]

yes, but it can lead to breaking changes in AEX-2

these will be handled with sample implementation on AEX finalization. No need to worry I think right now.

[davidyuk]

for some of the issues stated I suggest you to please re-read the proposal

for which issues?

[shekhar-shubhendu]

Wallet methods

• what is return value of aepp.get.address method?

Already part of the AEX. Please re-read.

• in what format tx should be passed to aepp.request.sign method? I see several options: hex string, an array of bytes, tx_.. string, the current explanation is too ambiguous

Will be added.

• in what format tx returned from aepp.request.sign method?

Will be added. same as above.

• for what reason aepp.request.sign and other methods should return id received in arguments?

Already part of the AEX. Please re-read.

Aepp methods

• what is return value of wallet.get.network method?

Already part of the AEX. Please re-read.

• how aepp can use a list of connected account returned from wallet.update.address if it can't switch between them? We either should drop it or add a method for account switching.
• can wallet.update.address be simplified by extracting of getting a list of connected accounts into a separate method?

Not required.

• wallet.update.address method should explain parameters explicitly, not only by providing an example

Not required.

• for what reason wallet.broadcast.tx and wallet.verify.tx methods?

Already part of the AEX. Please re-read.

Common issues

• add errors that can be thrown by method to explanation of every method

Error explation are descriptive enough.

• how aepp.update.network and wallet.get.network methods are supposed to work?

Already part of the AEX. Please re-read.

[davidyuk]

Will be added.

Can you explain it better than "Currently supported format: tx_ string"? Maybe add a link to some document explaining what is tx_ string? #34, #35

for what reason aepp.request.sign and other methods should return id received in arguments?

Already part of the AEX. Please re-read.

I can't find, can you point to specific part?

for what reason wallet.broadcast.tx and wallet.verify.tx methods?

Already part of the AEX. Please re-read.

Yes, I see them, in which cases they are necessary?

Error explation are descriptive enough

So, let's remove errors explanations from wallet.broadcast.tx, wallet.verify.tx methods for consistency.

[davidyuk]

All unresolved issues are moved to separate issues