feat: add key block hash to activities #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thepiwo
approved these changes
Dec 31, 2022
jyeshe
reviewed
Jan 2, 2023
lib/ae_mdw/activities.ex
Outdated
Comment on lines
177
to
181
| Enum.map_reduce(activities_locators_data, {nil, nil}, fn | ||
| {{height, _txi, _local_idx}, _data} = locator, {height, enc_kb_hash} = kb_info -> | ||
| {{enc_kb_hash, locator}, kb_info} | ||
|
|
||
| {{height, _txi, _local_idx}, _data} = locator, _kb_info -> |
There was a problem hiding this comment.
If the accumulator won't be used it can be simplified with a Enum.map
There was a problem hiding this comment.
Could you double check the intention here? kb_info is always a tuple of 2 elements and the locator has the same format for both clauses matching always with the first one.
lib/ae_mdw/activities.ex
Outdated
|
|
||
| %{ | ||
| height: height, | ||
| key_block_hash: key_block_hash, |
There was a problem hiding this comment.
Depending on the requirement for key block information, instead of key_block_hash, or additionally to it, could be the block_hash with the micro block like /txs, to indicate the exact its location.
There was a problem hiding this comment.
This is a good idea, I'm going to implement it this way
jyeshe
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.