New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/channels #93

Merged
merged 137 commits into from Jan 11, 2019

Conversation

Projects
None yet
3 participants
@mpowaga
Copy link
Member

mpowaga commented Oct 9, 2018

No description provided.

mpowaga and others added some commits Aug 13, 2018

Init CLI interface
Implement basic functionality for chain and wallet
Implement sub-commands using commander.js
Implement chain, crypto, wallet(spend)
Create base interface for wallet cli
Grab keypair from constructor or get it from ENV
Implement create wallet
Parse wallet name
Refactor code
Add error handlers
Implement parsing keys from fs
Add aecli-contract
Validate hash before sent tot API
init AENS module
Refactor code

mpowaga and others added some commits Nov 12, 2018

@mpowaga

This comment has been minimized.

Copy link
Member Author

mpowaga commented Nov 15, 2018

@ricricucit I've removed proxy.

ricricucit added some commits Nov 15, 2018

@ricricucit

This comment has been minimized.

Copy link
Collaborator

ricricucit commented Dec 4, 2018

@mpowaga for some reason, tests always get stuck and stay there forever...and I have to stop them manually. E.g.: https://ci.aepps.com/blue/organizations/jenkins/aepp-sdk-js/detail/PR-93/27/pipeline

@mpowaga

This comment has been minimized.

Copy link
Member Author

mpowaga commented Dec 4, 2018

@ricricucit Following tests don't work with epoch v1.0.0.

  • can post update and reject
  • can close a channel
  • can reestablish a channel

Perhaps mocha.retries(3) should be reduced to mocha.retries(1) or removed.

@ricricucit

This comment has been minimized.

Copy link
Collaborator

ricricucit commented Dec 7, 2018

Mh...I see. Can you please check this issue? so I can eventually merge this branch... 😄

@mpowaga

This comment has been minimized.

Copy link
Member Author

mpowaga commented Dec 11, 2018

@ricricucit These issues need to be fixed in epoch so we need to wait a bit longer.

@ricricucit

This comment has been minimized.

Copy link
Collaborator

ricricucit commented Dec 11, 2018

Is anyone in the core team aware of this?

@mpowaga

This comment has been minimized.

Copy link
Member Author

mpowaga commented Dec 11, 2018

Yes, I talked with Dimitar, though we could also let them know that this PR is blocked by these issues.

@ricricucit

This comment has been minimized.

Copy link
Collaborator

ricricucit commented Dec 11, 2018

Cool, thanks. Ok, so let's see what happens if I mention @velzevur here! 😊

ricricucit and others added some commits Dec 18, 2018

@ricricucit

This comment has been minimized.

Copy link
Collaborator

ricricucit commented Jan 11, 2019

Glad to see tests passing! 👏

@ricricucit ricricucit merged commit 759f48a into develop Jan 11, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@noandrea noandrea deleted the feature/channels branch Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment