Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to sdk3.0.0 node 2.3.0 nonfungible token contracts #37

Merged
merged 18 commits into from May 7, 2019

Conversation

alekseytsekov
Copy link
Contributor

No description provided.

Copy link
Member

@hanssv hanssv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't look at the JS-parts... But apart from the unnecessary(?) SafeMath stuff the Sophia code looks much better!

Copy link
Contributor

@mradkov mradkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've looked over the Sophia part only.

libraries/NonFungibleToken/contracts/non-fungible.aes Outdated Show resolved Hide resolved
libraries/NonFungibleToken/contracts/math.aes Outdated Show resolved Hide resolved
libraries/NonFungibleToken/contracts/non-fungible.aes Outdated Show resolved Hide resolved
libraries/NonFungibleToken/contracts/non-fungible.aes Outdated Show resolved Hide resolved
libraries/NonFungibleToken/contracts/non-fungible.aes Outdated Show resolved Hide resolved
libraries/NonFungibleToken/contracts/non-fungible.aes Outdated Show resolved Hide resolved
@thepiwo
Copy link
Contributor

thepiwo commented May 7, 2019

@alekseytsekov should we merge?

@thepiwo thepiwo merged commit 9590c92 into master May 7, 2019
@maptuhec maptuhec removed the review label May 7, 2019
@mradkov mradkov deleted the update-sdk240-node-230-lib-nonfungible-token branch June 8, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants