Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify getting protocol version in primops #2769

Merged
merged 4 commits into from Sep 12, 2019

Conversation

@jur0
Copy link
Contributor

jur0 commented Sep 11, 2019

PT-168441677

This is a preparatory PR for fork signalling.

Instead of extensive use of aec_hard_forks:protocol_effective_at_height, it's simpler just to get the protocol version from state.

@jur0 jur0 added the status/wip label Sep 11, 2019
@jur0 jur0 force-pushed the simplify-getting-protocol-version-in-primops branch from 642bef9 to 2b331bc Sep 11, 2019
@jur0 jur0 removed the status/wip label Sep 11, 2019
@jur0 jur0 requested review from hanssv, gorillainduction and sennui Sep 11, 2019
@jur0 jur0 force-pushed the simplify-getting-protocol-version-in-primops branch from e327839 to bb23092 Sep 11, 2019
@jur0 jur0 force-pushed the simplify-getting-protocol-version-in-primops branch from bb23092 to af8952e Sep 11, 2019
Copy link
Contributor

hanssv left a comment

OK, we need to make a decision, should we keep changing things or should we try to reach a stable state where we release LIMA

The PR in itself looks harmless - but...

@jur0

This comment has been minimized.

Copy link
Contributor Author

jur0 commented Sep 12, 2019

I'm trying to get the harmless refactoring PRs in now. The ones that break API/change functionality will go after Lima.

@hanssv
hanssv approved these changes Sep 12, 2019
@sennui
sennui approved these changes Sep 12, 2019
@jur0 jur0 merged commit 3fa932f into master Sep 12, 2019
26 checks passed
26 checks passed
build_test_deploy Workflow: build_test_deploy
Details
ci/circleci: aevm_tests Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_otp21 Your tests passed on CircleCI!
Details
ci/circleci: build_uml_diagrams Your tests passed on CircleCI!
Details
ci/circleci: docker_smoke_tests Your tests passed on CircleCI!
Details
ci/circleci: docker_system_smoke_tests Your tests passed on CircleCI!
Details
ci/circleci: eunit_fortuna Your tests passed on CircleCI!
Details
ci/circleci: eunit_lima Your tests passed on CircleCI!
Details
ci/circleci: eunit_minerva Your tests passed on CircleCI!
Details
ci/circleci: eunit_roma Your tests passed on CircleCI!
Details
ci/circleci: linux_package Your tests passed on CircleCI!
Details
ci/circleci: rebar_lock_check Your tests passed on CircleCI!
Details
ci/circleci: static_analysis Your tests passed on CircleCI!
Details
ci/circleci: static_analysis_otp21 Your tests passed on CircleCI!
Details
ci/circleci: test_fortuna Your tests passed on CircleCI!
Details
ci/circleci: test_lima Your tests passed on CircleCI!
Details
ci/circleci: test_lima_otp21 Your tests passed on CircleCI!
Details
ci/circleci: test_minerva Your tests passed on CircleCI!
Details
ci/circleci: test_mnesia_leveled Your tests passed on CircleCI!
Details
ci/circleci: test_mnesia_rocksdb Your tests passed on CircleCI!
Details
ci/circleci: test_roma Your tests passed on CircleCI!
Details
ci/circleci: uat_tests Your tests passed on CircleCI!
Details
ci/circleci: upload_build_artifacts Your tests passed on CircleCI!
Details
ci/circleci: windows_package Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@jur0 jur0 deleted the simplify-getting-protocol-version-in-primops branch Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.