Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tx checks in mempool against fixed on-chain environment #2774

Merged
merged 1 commit into from Sep 12, 2019

Conversation

@jur0
Copy link
Contributor

jur0 commented Sep 12, 2019

PT-168453337

Preparatory PR for fork signalling.

It reads the on-chain environment just once and performs checks against it. It removes 2 db reads so the checks should be faster now. Also, it removes call to aec_hard_forks:protocol_effective_at_height.

@jur0 jur0 added status/wip and removed status/wip labels Sep 12, 2019
@jur0 jur0 requested review from hanssv, gorillainduction, velzevur and sennui Sep 12, 2019
@hanssv
hanssv approved these changes Sep 12, 2019
@jur0 jur0 requested a review from skkw Sep 12, 2019
@skkw
skkw approved these changes Sep 12, 2019
@jur0 jur0 merged commit d27e85b into master Sep 12, 2019
27 checks passed
27 checks passed
build_test_deploy Workflow: build_test_deploy
Details
ci/circleci: aevm_tests Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build_otp21 Your tests passed on CircleCI!
Details
ci/circleci: build_uml_diagrams Your tests passed on CircleCI!
Details
ci/circleci: docker_smoke_tests Your tests passed on CircleCI!
Details
ci/circleci: docker_system_smoke_tests Your tests passed on CircleCI!
Details
ci/circleci: eunit_fortuna Your tests passed on CircleCI!
Details
ci/circleci: eunit_lima Your tests passed on CircleCI!
Details
ci/circleci: eunit_minerva Your tests passed on CircleCI!
Details
ci/circleci: eunit_roma Your tests passed on CircleCI!
Details
ci/circleci: linux_package Your tests passed on CircleCI!
Details
ci/circleci: rebar_lock_check Your tests passed on CircleCI!
Details
ci/circleci: static_analysis Your tests passed on CircleCI!
Details
ci/circleci: static_analysis_otp21 Your tests passed on CircleCI!
Details
ci/circleci: test_fortuna Your tests passed on CircleCI!
Details
ci/circleci: test_lima Your tests passed on CircleCI!
Details
ci/circleci: test_lima_otp21 Your tests passed on CircleCI!
Details
ci/circleci: test_minerva Your tests passed on CircleCI!
Details
ci/circleci: test_mnesia_leveled Your tests passed on CircleCI!
Details
ci/circleci: test_mnesia_rocksdb Your tests passed on CircleCI!
Details
ci/circleci: test_roma Your tests passed on CircleCI!
Details
ci/circleci: uat_tests Your tests passed on CircleCI!
Details
ci/circleci: upload_build_artifacts Your tests passed on CircleCI!
Details
ci/circleci: windows_package Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@jur0 jur0 deleted the PT-168453337-refactor-mempool-tx-checks branch Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.