Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial docs addition of close_solo and settle #362

Merged
merged 2 commits into from Jun 20, 2019

Conversation

Projects
None yet
3 participants
@uwiger
Copy link
Contributor

commented May 29, 2019

See PT #166056472

  • Initial documentation of the close_solo and settle state channel requests
  • Go through and update channels_api_usage.md to reflect the new on_chain_tx messages.
  • Update the example jsonrpc logs

@uwiger uwiger requested review from velzevur and lucafavatella May 29, 2019

resulting transaction will include the latest mutually signed offchain state,
or the empty string, indicating that the latest state is what's on the chain.

The `channel_close_solo` transaction only needs a single signature, and is described in more detail in [this section](#channel-solo-close).

This comment has been minimized.

Copy link
@lucafavatella

lucafavatella May 29, 2019

Contributor

Can a wrapping generic account meta tx be provided instead of a signature?

It would be nice to consider signature-vs-generic-accounts in new docs. I expect other docs needs review fine-tuning.

This comment has been minimized.

Copy link
@velzevur

velzevur May 30, 2019

Contributor

@lucafavatella I consider this as part of my PT SC FSM: GA awareness

@lucafavatella

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

Shall /channels/README.md#overview be updated?

@uwiger

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2019

I don't really see what in the README needs to change, except of course for the main state diagram which was obsolete even before these changes. I am working on a better way to visualize the state machines, but that's a larger project.

@lucafavatella
Copy link
Contributor

left a comment

Please check conflicts with #367.

Also beware if this merged before #367 then #367 may need further update ("signed" words introduced in this PR).

@velzevur

This comment has been minimized.

Copy link
Contributor

commented Jun 20, 2019

I will rebase and adapt #367 after this PR is merged

@uwiger uwiger merged commit 3d7c855 into master Jun 20, 2019

@uwiger uwiger deleted the PT-166056472-document-solo-closing branch Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.