Skip to content

Remove retired ChannelRuntime direct callback endpoint#673

Merged
potter-sun merged 2 commits into
devfrom
fix/issue-671
May 18, 2026
Merged

Remove retired ChannelRuntime direct callback endpoint#673
potter-sun merged 2 commits into
devfrom
fix/issue-671

Conversation

@eanzhao
Copy link
Copy Markdown
Contributor

@eanzhao eanzhao commented May 18, 2026

Summary

  • Remove the retired direct platform callback route from ChannelCallbackEndpoints.
  • Drop the direct_callback_retired diagnostic path that only existed for that route.
  • Add route coverage proving ChannelRuntime no longer registers callback-style /api/channels/.../callback/... routes.
  • Update runtime guidance and cutover docs to point only at NyxID relay ingress.

Fixes #671.

Validation

  • dotnet test test/Aevatar.GAgents.ChannelRuntime.Tests/Aevatar.GAgents.ChannelRuntime.Tests.csproj --nologo
  • dotnet test test/Aevatar.AI.Tests/Aevatar.AI.Tests.csproj --nologo --filter "FullyQualifiedName~NyxIdChatGAgentTests|FullyQualifiedName~NyxIdChatEndpointsCoverageTests"
  • bash tools/ci/test_stability_guards.sh
  • git diff --check

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.31%. Comparing base (74d5afd) to head (ccb5fd2).
⚠️ Report is 3 commits behind head on dev.

@@            Coverage Diff             @@
##              dev     #673      +/-   ##
==========================================
- Coverage   82.31%   82.31%   -0.01%     
==========================================
  Files         932      932              
  Lines       59485    59485              
  Branches     7805     7805              
==========================================
- Hits        48965    48964       -1     
+ Misses       7160     7159       -1     
- Partials     3360     3362       +2     
Flag Coverage Δ
ci 82.31% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

3. Switch the Lark console callback URL to Nyx
4. Remove the direct Aevatar Lark callback path from the supported runtime contract
5. Return `410 Gone` for `POST /api/channels/lark/callback/{registrationId}` or delete that endpoint entirely
5. Historical transition note: the retired direct endpoint could temporarily return `410 Gone`; the current runtime deletes the direct endpoint entirely.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[codex] severity=major, category=arch

This mutates an existing ADR even though CLAUDE.md says ADRs are immutable and may only be superseded (docs/adr/ governance). Note ADR-0011 is already status: superseded (superseded by ADR-0013), so editing its "required order" step is both a governance violation and unnecessary — the authoritative contract now lives in ADR-0013. Recommend reverting this ADR-0011 edit entirely; if a current-runtime clarification is needed, put it in the runbook/canon docs instead.

EnvironmentName = "Development",
});

var app = builder.Build();
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[v4-pro] severity=minor, category=test

WebApplication created by builder.Build() implements IAsyncDisposable but is never disposed, leaking the host and its DI container. Fix: await using var app = builder.Build(); and make the test async. Note: the sibling test MapChannelCallbackEndpoints_ShouldRequireAuthorization_ForDiagnosticErrors has the identical undisposed pattern — if you fix this, fix both for consistency.

@potter-sun potter-sun marked this pull request as ready for review May 18, 2026 09:05
@potter-sun potter-sun merged commit 12f4ede into dev May 18, 2026
13 checks passed
@potter-sun potter-sun deleted the fix/issue-671 branch May 18, 2026 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove retired ChannelRuntime direct platform callback endpoint

2 participants