Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle empty numbers #160

Merged
merged 1 commit into from Jul 16, 2021
Merged

Handle empty numbers #160

merged 1 commit into from Jul 16, 2021

Conversation

saramorillon
Copy link
Contributor

The num() validators considers empty string as valid numbers because +"" result in 0, while parseFloat("") results in NaN

@af af merged commit 0c790b9 into af:main Jul 16, 2021
@af
Copy link
Owner

af commented Jul 16, 2021

Good catch, thanks for the PR! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants