Skip to content

Commit

Permalink
apci: assign memory regions to ich9 lpc device
Browse files Browse the repository at this point in the history
Get rid of get_system_io() usage.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
  • Loading branch information
kraxel committed Jan 4, 2013
1 parent 56e5b2a commit 503b19f
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 4 deletions.
6 changes: 4 additions & 2 deletions hw/acpi_ich9.c
Expand Up @@ -202,11 +202,13 @@ static void pm_powerdown_req(Notifier *n, void *opaque)
acpi_pm1_evt_power_down(&pm->acpi_regs);
}

void ich9_pm_init(ICH9LPCPMRegs *pm, qemu_irq sci_irq, qemu_irq cmos_s3)
void ich9_pm_init(PCIDevice *lpc_pci, ICH9LPCPMRegs *pm,
qemu_irq sci_irq, qemu_irq cmos_s3)
{
memory_region_init(&pm->io, "ich9-pm", ICH9_PMIO_SIZE);
memory_region_set_enabled(&pm->io, false);
memory_region_add_subregion(get_system_io(), 0, &pm->io);
memory_region_add_subregion(pci_address_space_io(lpc_pci),
0, &pm->io);

acpi_pm_tmr_init(&pm->acpi_regs, ich9_pm_update_sci_fn, &pm->io);
acpi_pm1_evt_init(&pm->acpi_regs, ich9_pm_update_sci_fn, &pm->io);
Expand Down
4 changes: 3 additions & 1 deletion hw/acpi_ich9.h
Expand Up @@ -30,9 +30,11 @@ typedef struct ICH9LPCPMRegs {
* PM1a_CNT_BLK = 2 in FADT so it is defined as uint16_t.
*/
ACPIREGS acpi_regs;

MemoryRegion io;
MemoryRegion io_gpe;
MemoryRegion io_smi;

uint32_t smi_en;
uint32_t smi_sts;

Expand All @@ -42,7 +44,7 @@ typedef struct ICH9LPCPMRegs {
Notifier powerdown_notifier;
} ICH9LPCPMRegs;

void ich9_pm_init(ICH9LPCPMRegs *pm,
void ich9_pm_init(PCIDevice *lpc_pci, ICH9LPCPMRegs *pm,
qemu_irq sci_irq, qemu_irq cmos_s3_resume);
void ich9_pm_iospace_update(ICH9LPCPMRegs *pm, uint32_t pm_io_base);
extern const VMStateDescription vmstate_ich9_pm;
Expand Down
2 changes: 1 addition & 1 deletion hw/lpc_ich9.c
Expand Up @@ -336,7 +336,7 @@ void ich9_lpc_pm_init(PCIDevice *lpc_pci, qemu_irq cmos_s3)
qemu_irq *sci_irq;

sci_irq = qemu_allocate_irqs(ich9_set_sci, lpc, 1);
ich9_pm_init(&lpc->pm, sci_irq[0], cmos_s3);
ich9_pm_init(lpc_pci, &lpc->pm, sci_irq[0], cmos_s3);

ich9_lpc_reset(&lpc->d.qdev);
}
Expand Down

0 comments on commit 503b19f

Please sign in to comment.