Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Branch: dprintf.v1
Commits on Jan 27, 2013
  1. target-unicore32: Refactor debug output macros

    authored
    Make debug output compile-testable even if disabled.
    
    Signed-off-by: Andreas Färber <afaerber@suse.de>
  2. target-sparc: Refactor debug output macros

    authored
    Make debug output compile-testable even if disabled.
    
    Inline DEBUG_FEATURES and introduce FEATURES_DPRINTF() in cpu.c.
    Inline DEBUG_MMU in ldst_helper.c but leave DPRINTF_MMU() outside.
    Inline DEBUG_{MXCC,ASI} in ldst_helper.c.
    
    Signed-off-by: Andreas Färber <afaerber@suse.de>
  3. target-s390x: Refactor debug output macros

    authored
    Make debug output compile-testable even if disabled.
    
    Inline S390X_DEBUG_DISAS in translate.c.
    
    Signed-off-by: Andreas Färber <afaerber@suse.de>
  4. target-ppc: Refactor debug output macros

    authored
    Make debug output compile-testable even if disabled.
    
    Inline DEBUG_OP check in excp_helper.c.
    Inline LOG_MMU_STATE() in mmu_helper.c.
    Inline PPC_DEBUG_SPR check in translate_init.c.
    
    Signed-off-by: Andreas Färber <afaerber@suse.de>
  5. target-openrisc: Refactor debug output macros

    authored
    Make debug output compile-testable even if disabled.
    
    Signed-off-by: Andreas Färber <afaerber@suse.de>
  6. target-microblaze: Refactor debug output macros

    authored
    Make debug output compile-testable even if disabled.
    
    Drop unused D(x) macros.
    
    Signed-off-by: Andreas Färber <afaerber@suse.de>
  7. target-lm32: Refactor debug output macros

    authored
    Already enabled and thus compile-tested, but align with other targets.
    
    Signed-off-by: Andreas Färber <afaerber@suse.de>
  8. target-i386: Refactor debug output macros

    authored
    Make debug output compile-testable even if disabled.
    
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    Cc: Richard Henderson <rth@twiddle.net>
  9. target-cris: Refactor debug output macros

    authored
    Make debug output compile-testable even if disabled.
    
    Introduce DPRINTF() in helper.c and consolidate stdout and stderr
    output.
    Introduce DPRINTF() in mmu.c and inline remaining D(x).
    Drop unused D(x) macro in op_helper.c.
    
    Signed-off-by: Andreas Färber <afaerber@suse.de>
  10. target-alpha: Refactor debug output macros

    authored
    Make LOG_DISAS() arguments compile-testable even if disabled.
    
    Signed-off-by: Andreas Färber <afaerber@suse.de>
  11. target-cris/mmu.c: Update Coding Style of cris_mmu_translate_page()

    authored
    Reindent, add braces, adjust whitespace.
    
    Prepares for touching the logging macros.
    
    Signed-off-by: Andreas Färber <afaerber@suse.de>
  12. target-cris/helper.c: Update Coding Style

    authored
    Reindent, add missing braces and drop/adjust whitespace.
    
    Prepares for CPUArchState-to-CPUState field movements in
    cpu_cris_handle_mmu_fault(), do_interruptv10() and do_interrupt().
    The remaining functions were so minor that they can be fixed in one go.
    
    Signed-off-by: Andreas Färber <afaerber@suse.de>
  13. target-sparc: Fix debug output for DEBUG_MMU

    authored
    Signed-off-by: Andreas Färber <afaerber@suse.de>
  14. target-s390x: Fix debug output (continued)

    authored
    Since its introduction in d5a4396
    (s390x: helper functions for system emulation) the variable name was
    raddr. Fix this.
    
    Signed-off-by: Andreas Färber <afaerber@suse.de>
  15. target-s390x: Fix debug output

    authored
    Commit 71e4708 (target-s390x: fix
    style) renamed the cpu_s390x_handle_mmu_fault() argument from _vaddr to
    orig_vaddr. Update the debug output code.
    
    Signed-off-by: Andreas Färber <afaerber@suse.de>
  16. target-ppc: Fix build for PPC_DEBUG_DISAS

    authored
    In r5949 / 76db3ba (target-ppc: memory
    load/store rework) variable little_endian was replaced with ctx.le_mode.
    Update the debug code.
    
    Signed-off-by: Andreas Färber <afaerber@suse.de>
  17. target-ppc: Fix unused variable warning for FLUSH_ALL_TLBS

    authored
    Signed-off-by: Andreas Färber <afaerber@suse.de>
  18. target-ppc: Fix target_ulong vs. hwaddr format mismatches

    authored
    To keep log format backwards compatible, cast to target_ulong
    rather than using HWADDR_PRIx.
    
    Signed-off-by: Andreas Färber <afaerber@suse.de>
  19. target-cris: Build fix for debug output

    authored
    Around r3361 (81fdc5f) env->debug1 used
    to contain the address of an MMU fault. This is now written into
    env->pregs[PR_EDA] instead.
    
    Signed-off-by: Andreas Färber <afaerber@suse.de>
  20. @edgarigl

    xilinx_ethlite: Avoid build warnings in debug code

    edgarigl authored
    Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
  21. @pete128 @edgarigl

    m25p80.c: Return state to IDLE after COLLECTING

    pete128 authored edgarigl committed
    Default to moving back to the IDLE state after the COLLECTING_DATA
    state. For a well behaved guest this patch has no consequence, but
    A bad guest could crash QEMU by using one of the erase commands
    followed by a longer than 5 byte argument (undefined behaviour).
    
    Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
    Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
Commits on Jan 26, 2013
  1. @pete128 @edgarigl

    xilinx_ethlite: Flush queued packets on SW service

    pete128 authored edgarigl committed
    Software services a received packet by clearing the CTRL_S bit in the RX_CTRLn
    register. If this bit is cleared, flush any packets queued for the device.
    
    Reported-by: John Williams <john.williams@xilinx.com>
    Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
    Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
  2. @pete128 @edgarigl

    xilinx_ethlite: fix eth_can_rx() for ping-pong

    pete128 authored edgarigl committed
    The eth_can_rx() function only checks the first buffers status ("ping"). The
    controller should be able to receive into "pong" when ping-pong is enabled.
    Checks the active buffer (either "ping" or "pong") when determining can_rx()
    rather than just testing "ping".
    
    Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
    Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
  3. @blueswirl

    Merge branch 'ppc-for-upstream' of git://repo.or.cz/qemu/agraf

    blueswirl authored
    * 'ppc-for-upstream' of git://repo.or.cz/qemu/agraf:
      PPC: e500: Select MPIC v4.2 on ppce500 platform
      PPC: e500: fix mpic_iack address
      openpic: add basic support for MPIC v4.2
      openpic: fix timer address decoding
      openpic: fix remaining issues from idr-to-destmask conversion
      pseries: Adjust default VIO address allocations to play better with libvirt
      pseries: Improve handling of multiple PCI host bridges
      target-ppc: Give a meaningful error if too many threads are specified
      cuda: Move ADB bus into CUDA state
      adb: QOM'ify ADB devices
      adb: QOM'ify Apple Desktop Bus
      cuda: QOM'ify CUDA
      ide/macio: QOM'ify MacIO IDE
      mac_nvram: QOM'ify MacIO NVRAM
      mac_nvram: Mark as Big Endian
      mac_nvram: Clean up public API
      macio: Split MacIO in two
      macio: Delay qdev init until all fields are initialized
      macio: QOM'ify some more
      ppc: Move Mac machines to hw/ppc/
  4. @blueswirl

    tests: Add gcov support for x86_64 qtest

    authored blueswirl committed
    Since x86_64 is a superset of i386 and reuses all its test cases, adopt
    all the i386 gcov source files as well, substituting their paths
    appropriately.
    
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
  5. @blueswirl

    tests: Add gcov support for sparc64 qtest

    authored blueswirl committed
    m48t59-test is individually being executed for sparc and sparc64, so add
    the gcov source file for sparc64 as well.
    
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
  6. @blueswirl

    tests: Fix gcov typo for tmp105-test

    authored blueswirl committed
    Commit 6e99890 introduced a new qtest
    test case but misspelled gcov, leading to no coverage analysis. Fix it.
    
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
  7. @blueswirl

    vmware_vga: fix out of bounds and invalid rects updating

    Michael Tokarev authored blueswirl committed
    This is a follow up for several attempts to fix this issue.
    
    Previous incarnations:
    
    1. http://thread.gmane.org/gmane.linux.ubuntu.bugs.general/3156089
    https://bugs.launchpad.net/bugs/918791
    "qemu-kvm dies when using vmvga driver and unity in the guest" bug.
    Fix by Serge Hallyn:
     https://launchpadlibrarian.net/94916786/qemu-vmware.debdiff
    This fix is incomplete, since it does not check width and height
    for being negative.  Serge weren't sure if that's the right place
    to fix it, maybe the fix should be up the stack somewhere.
    
    2. http://thread.gmane.org/gmane.comp.emulators.qemu/166064
    by Marek Vasut: "vmware_vga: Redraw only visible area"
    
    This one adds the (incomplete) check to vmsvga_update_rect_delayed(),
    the routine just queues the rect updating but does no interesting
    stuff.  It is also incomplete in the same way as patch by Serge,
    but also does not touch width&height at all after adjusting x&y,
    which is wrong.
    
    As far as I can see, when processing guest requests, the device
    places them into a queue (vmsvga_update_rect_delayed()) and
    processes this queue in different place/time, namely, in
    vmsvga_update_rect().  Sometimes, vmsvga_update_rect() is
    called directly, without placing the request to the gueue.
    This is the place this patch changes, which is the last
    (deepest) in the stack.  I'm not sure if this is the right
    place still, since it is possible we have some queue optimization
    (or may have in the future) which will be upset by negative/wrong
    values here, so maybe we should check for validity of input
    right when receiving request from the guest (and maybe even
    use unsigned types there).  But I don't know the protocol
    and implementation enough to have a definitive answer.
    
    But since vmsvga_update_rect() has other sanity checks already,
    I'm adding the missing ones there as well.
    
    Cc'ing BALATON Zoltan and Andrzej Zaborowski who shows in `git blame'
    output and may know something in this area.
    
    If this patch is accepted, it should be applied to all active
    stable branches (at least since 1.1, maybe even before), with
    minor context change (ds_get_*(s->vga.ds) => s->*).  I'm not
    Cc'ing -stable yet, will do it explicitly once the patch is
    accepted.
    
    BTW, these checks use fprintf(stderr) -- it should be converted
    to something more appropriate, since stderr will most likely
    disappear somewhere.
    
    Cc: Marek Vasut <marex@denx.de>
    CC: Serge Hallyn <serge.hallyn@ubuntu.com>
    Cc: BALATON Zoltan <balaton@eik.bme.hu>
    Cc: Andrzej Zaborowski <balrogg@gmail.com>
    Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
    Reviewed-by: Marek Vasut <marex@denx.de>
    Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
    Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
  8. @blueswirl

    tests: add fuzzing to visitor tests

    blueswirl authored
    Perform input tests on random data.
    
    Improvement to code coverage for qapi/string-input-visitor.c
    is about 3 percentage points.
    
    Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
  9. @bonzini @blueswirl

    build: remove *.lo, *.a, *.la files from all subdirectories on make c…

    bonzini authored blueswirl committed
    …lean
    
    .lo files in stubs/, util/ and libcacard/ were not cleaned.
    Fix this.
    
    Cc: Blue Swirl <blauwirbel@gmail.com>
    Reported-by: Stefan Hajnoczi <stefanha@redhat.com>
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
    Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
    Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
    Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
  10. @pm215 @blueswirl

    hw/arm_boot: Align device tree to 4KB boundary, not page

    pm215 authored blueswirl committed
    Align the device tree blob to a 4KB boundary, not to QEMU's
    idea of a page boundary -- the latter is the smallest possible
    page size for the architecture, which on ARM is 1KB.
    The documentation for Linux does not impose separation
    or alignment requirements on the device tree blob, but
    in practice some kernels will happily trash the entire
    page the initrd ends in after they have finished uncompressing
    the initrd. So 4KB-align the DTB to ensure it does not get
    trampled by these kernels.
    
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
    Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
  11. @pm215 @blueswirl

    qemu-char: Avoid unused variable warning in some configs

    pm215 authored blueswirl committed
    Avoid unused variable warnings:
    qemu-char.c: In function 'qmp_chardev_open_port':
    qemu-char.c:3132: warning: unused variable 'fd'
    qemu-char.c:3132: warning: unused variable 'flags'
    
    in configurations with neither HAVE_CHARDEV_TTY nor
    HAVE_CHARDEV_PARPORT set.
    
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
    Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
  12. @blueswirl

    make_device_config.sh: Fix target path in generated dependency file

    authored blueswirl committed
    config-devices.mak.d is included from Makefile.target, i.e. from inside
    the *-softmmu/ directory. It included the directory path, so never
    applied to the actual ./config-devices.mak. Symptoms were spurious
    build failures due to missing dependency on default-configs/pci.mak.
    
    Fix this by using `basename` to strip the directory path.
    
    Reported-by: Gerhard Wiesinger <lists@wiesinger.com>
    Cc: qemu-stable@nongnu.org
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
  13. @blueswirl

    fw_cfg: Drop a few superfluous initializers

    Markus Armbruster authored blueswirl committed
    Signed-off-by: Markus Armbruster <armbru@redhat.com>
    Reviewed-by: Laszlo Ersek <lersek@redhat.com>
    Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
  14. @blueswirl

    fw_cfg: Splash image loader can overrun a stack variable, fix

    Markus Armbruster authored blueswirl committed
    read_splashfile() passes the address of an int variable as size_t *
    parameter to g_file_get_contents(), with a cast to gag the compiler.
    
    No problem on machines where sizeof(size_t) == sizeof(int).
    
    Happens to work on my x86_64 box (64 bit little endian): the least
    significant 32 bits of the file size end up in the right place
    (caller's variable file_size), and the most significant 32 bits
    clobber a place that gets assigned to before its next use (caller's
    variable file_type).
    
    I'd expect it to break on a 64 bit big-endian box.
    
    Fix up the variable types and drop the problematic cast.
    
    Signed-off-by: Markus Armbruster <armbru@redhat.com>
    Reviewed-by: Laszlo Ersek <lersek@redhat.com>
    Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
Something went wrong with that request. Please try again.