Permalink
Commits on Apr 18, 2016
  1. MAINTAINERS: Drop target-i386 from CPU subsystem

    X86CPU QOM type is in good hands and actively maintained these days, so
    drop it from the generic QOM CPU subsystem.
    
    Some refactorings and design questions will still intersect, but review
    and discussions of individual series can still take place while opting out
    of general X86CPU patch review.
    
    Cc: Eduardo Habkost <ehabkost@redhat.com>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    committed Feb 12, 2016
  2. Merge remote-tracking branch 'remotes/mcayland/tags/qemu-openbios-sig…

    …ned' into staging
    
    Update OpenBIOS images
    
    # gpg: Signature made Mon 18 Apr 2016 09:39:31 BST using RSA key ID AE0F321F
    # gpg: Good signature from "Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>"
    
    * remotes/mcayland/tags/qemu-openbios-signed:
      Update OpenBIOS images
    
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
    pm215 committed Apr 18, 2016
  3. Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.6-201604…

    …18' into staging
    
    ppc patch queue for 2-16-04-18
    
    Three bugfixe patches for 2.6 here.
    * Two for bad implementation of some of the strong load/store
      instructions
    
    * One for bad migration of the XER register.  This is a regression
      from 2.5, cause by a change in the way we represent at XER during
      runtime.
    
    # gpg: Signature made Mon 18 Apr 2016 06:17:03 BST using RSA key ID 20D9B392
    # gpg: Good signature from "David Gibson <david@gibson.dropbear.id.au>"
    # gpg:                 aka "David Gibson (Red Hat) <dgibson@redhat.com>"
    # gpg:                 aka "David Gibson (ozlabs.org) <dgibson@ozlabs.org>"
    # gpg: WARNING: This key is not certified with sufficiently trusted signatures!
    # gpg:          It is not certain that the signature belongs to the owner.
    # Primary key fingerprint: 75F4 6586 AE61 A66C C44E  87DC 6C38 CACA 20D9 B392
    
    * remotes/dgibson/tags/ppc-for-2.6-20160418:
      ppc: Fix migration of the XER register
      ppc: Fix the bad exception NIP value and the range check in LSWX
      ppc: Fix the range check in the LSWI instruction
    
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
    pm215 committed Apr 18, 2016
  4. Merge remote-tracking branch 'remotes/otubo/tags/pull-seccomp-2016041…

    …6' into staging
    
    seccomp branch queue
    
    # gpg: Signature made Sat 16 Apr 2016 19:58:46 BST using RSA key ID 12F8BD2F
    # gpg: Good signature from "Eduardo Otubo (Software Engineer @ ProfitBricks) <eduardo.otubo@profitbricks.com>"
    # gpg: WARNING: This key is not certified with a trusted signature!
    # gpg:          There is no indication that the signature belongs to the owner.
    # Primary key fingerprint: 1C96 46B6 E1D1 C38A F2EC  3FDE FD0C FF5B 12F8 BD2F
    
    * remotes/otubo/tags/pull-seccomp-20160416:
      seccomp: adding sysinfo system call to whitelist
      seccomp: Whitelist cacheflush since 2.2.0 not 2.2.3
      configure: Enable seccomp sandbox for MIPS
    
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
    pm215 committed Apr 18, 2016
  5. Merge remote-tracking branch 'remotes/weil/tags/pull-wxx-20160415' in…

    …to staging
    
    wxx patch queue
    
    # gpg: Signature made Fri 15 Apr 2016 18:36:41 BST using RSA key ID 677450AD
    # gpg: Good signature from "Stefan Weil <sw@weilnetz.de>"
    # gpg:                 aka "Stefan Weil <stefan.weil@weilnetz.de>"
    # gpg:                 aka "Stefan Weil <stefan.weil@bib.uni-mannheim.de>"
    # gpg: WARNING: This key is not certified with sufficiently trusted signatures!
    # gpg:          It is not certain that the signature belongs to the owner.
    # Primary key fingerprint: 4923 6FEA 75C9 5D69 8EC2  B78A E08C 21D5 6774 50AD
    
    * remotes/weil/tags/pull-wxx-20160415:
      wxx: Fix broken TCP networking (regression)
    
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
    pm215 committed Apr 18, 2016
  6. Update OpenBIOS images

    Update OpenBIOS images to SVN r1395 built from submodule.
    
    Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
    mcayland committed Apr 18, 2016
  7. ppc: Fix migration of the XER register

    env->xer only holds the lower bits of the XER register nowadays, the
    SO, OV and CA bits are stored in separate variables (see the function
    cpu_write_xer() for details). Since the migration code currently only
    reads the "xer" variable, the upper bits are lost during migration.
    Fix it by using cpu_read_xer() instead.
    
    Signed-off-by: Thomas Huth <thuth@redhat.com>
    Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
    huth committed with dgibson Apr 15, 2016
  8. ppc: Fix the bad exception NIP value and the range check in LSWX

    The range checks in the LSWX instruction are completely insufficient:
    They do not take the wrap-around case into account, and the check
    "reg < rx" should be "reg <= rx" instead. Fix it by using the new
    lsw_reg_in_range() helper function that is already used for LSWI, too.
    
    Then there is a second problem: In case the INVAL exception is generated,
    the NIP value is wrong, it currently points to the instruction before
    the LSWX instruction. This is because gen_lswx() already decreases the
    NIP value by 4 (to be prepared for page fault exceptions), and
    powerpc_excp() later decreases it again by 4 while handling the program
    exception. So to get this right, we've got to undo the "- 4" from
    gen_lswx() here before calling helper_raise_exception_err().
    
    Signed-off-by: Thomas Huth <thuth@redhat.com>
    Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
    huth committed with dgibson Apr 14, 2016
  9. ppc: Fix the range check in the LSWI instruction

    There are two issues: First, the number of registers that are used has
    to be calculated with "(nb + 3) / 4" (i.e. round always up, not down).
    Second, the "start <= ra && (start + nr - 32) > ra" condition for the
    wrap-around case is wrong: It has to be tested with "||" instead of "&&".
    Since we can reuse this check later for the LSWX instruction, let's
    place the fixed code into a helper function, too.
    
    Signed-off-by: Thomas Huth <thuth@redhat.com>
    Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
    huth committed with dgibson Apr 14, 2016
Commits on Apr 16, 2016
  1. seccomp: adding sysinfo system call to whitelist

    Newer version of nss-softokn libraries (> 3.16.2.3) use sysinfo call
    so qemu using rbd image hang after start when run in sandbox mode.
    
    To allow using rbd images in sandbox mode we have to whitelist it.
    
    Signed-off-by: Miroslav Rezanina <mrezanin@redhat.com>
    Acked-by: Eduardo Otubo <eduardo.otubo@profitbricks.com>
    LaneWolf committed with otubo Mar 7, 2016
  2. seccomp: Whitelist cacheflush since 2.2.0 not 2.2.3

    The cacheflush system call (found on MIPS and ARM) has been included in
    the libseccomp header since 2.2.0, so include it back to that version.
    Previously it was only enabled since 2.2.3 since that is when it was
    enabled properly for ARM.
    
    This will allow seccomp support to be enabled for MIPS back to
    libseccomp 2.2.0.
    
    Signed-off-by: James Hogan <james.hogan@imgtec.com>
    Reviewed-By: Andrew Jones <drjones@redhat.com>
    Acked-by: Eduardo Otubo <eduardo.otubo@profitbricks.com>
    jahogan committed with otubo Apr 8, 2016
  3. configure: Enable seccomp sandbox for MIPS

    Enable seccomp on MIPS since libseccomp version 2.2.0 when MIPS support
    was first added.
    
    Signed-off-by: James Hogan <james.hogan@imgtec.com>
    Reviewed-by: Andrew Jones <drjones@redhat.com>
    Acked-by: Eduardo Otubo <eduardo.otubo@profitbricks.com>
    jahogan committed with otubo Apr 8, 2016
Commits on Apr 15, 2016
  1. wxx: Fix broken TCP networking (regression)

    It is broken since commit c619644.
    
    Reported-by: Michael Fritscher <michael@fritscher.net>
    Tested-by: Michael Fritscher <michael@fritscher.net>
    Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
    Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
    Signed-off-by: Stefan Weil <sw@weilnetz.de>
    stweil committed Apr 14, 2016
  2. Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into s…

    …taging
    
    Block layer patches for 2.6.0-rc3
    
    # gpg: Signature made Fri 15 Apr 2016 17:02:23 BST using RSA key ID C88F2FD6
    # gpg: Good signature from "Kevin Wolf <kwolf@redhat.com>"
    
    * remotes/kevin/tags/for-upstream:
      nbd: Don't kill server on client that doesn't request TLS
      nbd: fix assert() on qemu-nbd stop
      nbd: Don't fail handshake on NBD_OPT_LIST descriptions
      qemu-iotests: 041: More robust assertion on quorum node
      qemu-iotests: place valgrind log file in scratch dir
      qemu-iotests: tests: do not set unused tmp variable
      qemu-iotests: common.rc: drop unused _do()
      qemu-iotests: drop unused _within_tolerance() filter
      Fix pflash migration
      block: Don't ignore flags in blk_{,co,aio}_write_zeroes()
      block/vpc: update comments to be compliant w/coding guidelines
      block/vpc: set errp in vpc_open
      block/vpc: make checks on max table size a bit more lax
      block/vpc: Use the correct max sector count for VHD images
      block/vpc: use current_size field for XenConverter VHD images
      vpc: use current_size field for XenServer VHD images
      block/vpc: set errp in vpc_create
      block: Fix blk_aio_write_zeroes()
      qemu-io: Support 'aio_write -z'
    
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
    pm215 committed Apr 15, 2016
  3. Merge remote-tracking branch 'remotes/armbru/tags/pull-backends-2016-…

    …04-15' into staging
    
    hostmem-file: plug a small leak
    
    # gpg: Signature made Fri 15 Apr 2016 17:30:42 BST using RSA key ID EB918653
    # gpg: Good signature from "Markus Armbruster <armbru@redhat.com>"
    # gpg:                 aka "Markus Armbruster <armbru@pond.sub.org>"
    
    * remotes/armbru/tags/pull-backends-2016-04-15:
      hostmem-file: plug a small leak
    
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
    pm215 committed Apr 15, 2016
  4. Merge remote-tracking branch 'mreitz/tags/pull-block-for-kevin-2016-0…

    …4-15' into queue-block
    
    Block patches for 2.6.0-rc3.
    
    # gpg: Signature made Fri Apr 15 17:57:30 2016 CEST using RSA key ID E838ACAD
    # gpg: Good signature from "Max Reitz <mreitz@redhat.com>"
    
    * mreitz/tags/pull-block-for-kevin-2016-04-15:
      nbd: Don't kill server on client that doesn't request TLS
      nbd: fix assert() on qemu-nbd stop
      nbd: Don't fail handshake on NBD_OPT_LIST descriptions
      qemu-iotests: 041: More robust assertion on quorum node
      qemu-iotests: place valgrind log file in scratch dir
      qemu-iotests: tests: do not set unused tmp variable
      qemu-iotests: common.rc: drop unused _do()
      qemu-iotests: drop unused _within_tolerance() filter
    
    Signed-off-by: Kevin Wolf <kwolf@redhat.com>
    Kevin Wolf committed Apr 15, 2016
  5. nbd: Don't kill server on client that doesn't request TLS

    Upstream NBD documents (as of commit 4feebc95) that servers MAY
    choose to operate in a conditional mode, where it is up to the
    client whether to use TLS.  For qemu's case, we want to always be
    in FORCEDTLS mode, because of the risk of man-in-the-middle
    attacks, and since we never export more than one device; likewise,
    the qemu client will ALWAYS send NBD_OPT_STARTTLS as its first
    option.  But now that SELECTIVETLS servers exist, it is feasible
    to encounter a (non-qemu) client that is programmed to talk to
    such a server, and does not do NBD_OPT_STARTTLS first, but rather
    wants to probe if it can use a non-encrypted export.
    
    The NBD protocol documents that we should let such a client
    continue trying, on the grounds that maybe the client will get the
    hint to send NBD_OPT_STARTTLS, rather than immediately dropping
    the connection.
    
    Note that NBD_OPT_EXPORT_NAME is a special case: since it is the
    only option request that can't have an error return, we have to
    (continue to) drop the connection on that one; rather, what we are
    fixing here is that all other replies prior to TLS initiation tell
    the client NBD_REP_ERR_TLS_REQD, but keep the connection alive.
    
    Signed-off-by: Eric Blake <eblake@redhat.com>
    Message-id: 1460671343-18485-1-git-send-email-eblake@redhat.com
    Signed-off-by: Max Reitz <mreitz@redhat.com>
    Eric Blake committed with XanClic Apr 14, 2016
  6. nbd: fix assert() on qemu-nbd stop

    From time to time qemu-nbd is crashing on the following assert:
        assert(state == TERMINATING);
        nbd_export_closed
        nbd_export_put
        main
    and the state at the moment of the crash is evaluated to TERMINATE.
    
    During shutdown process of the client the nbd_client_thread thread sends
    SIGTERM signal and the main thread calls the nbd_client_closed callback.
    If the SIGTERM callback will be executed after change the state to
    TERMINATING, then the state will once again be TERMINATE.
    
    To solve the issue, we must change the state to TERMINATE only if the state
    is RUNNING. In the other case we are shutting down already.
    
    Signed-off-by: Pavel Butsykin <pbutsykin@virtuozzo.com>
    Signed-off-by: Denis V. Lunev <den@openvz.org>
    CC: Paolo Bonzini <pbonzini@redhat.com>
    Message-id: 1460629215-11567-1-git-send-email-den@openvz.org
    Signed-off-by: Max Reitz <mreitz@redhat.com>
    Pavel Butsykin committed with XanClic Apr 14, 2016
  7. nbd: Don't fail handshake on NBD_OPT_LIST descriptions

    The NBD Protocol states that NBD_REP_SERVER may set
    'length > sizeof(namelen) + namelen'; in which case the rest
    of the packet is a UTF-8 description of the export.  While we
    don't know of any NBD servers that send this description yet,
    we had better consume the data so we don't choke when we start
    to talk to such a server.
    
    Also, a (buggy/malicious) server that replies with length <
    sizeof(namelen) would cause us to block waiting for bytes that
    the server is not sending, and one that replies with super-huge
    lengths could cause us to temporarily allocate up to 4G memory.
    Sanity check things before blindly reading incorrectly.
    
    Signed-off-by: Eric Blake <eblake@redhat.com>
    Message-id: 1460077777-31004-1-git-send-email-eblake@redhat.com
    Reviewed-by: Alex Bligh <alex@alex.org.uk>
    Signed-off-by: Max Reitz <mreitz@redhat.com>
    Eric Blake committed with XanClic Apr 8, 2016
  8. qemu-iotests: 041: More robust assertion on quorum node

    Block nodes are now assigned names automatically, therefore the test
    case is fragile in using fixed indices in result. Introduce a method in
    iotests.py and do the matching more sensibly.
    
    Signed-off-by: Fam Zheng <famz@redhat.com>
    Message-id: 1460518995-1338-1-git-send-email-famz@redhat.com
    Signed-off-by: Max Reitz <mreitz@redhat.com>
    famz committed with XanClic Apr 13, 2016
  9. qemu-iotests: place valgrind log file in scratch dir

    Do not place the valgrind log file at a predictable path in a
    world-writable location. Use the common scratch directory (${TEST_DIR})
    instead.
    
    Signed-off-by: Sascha Silbe <silbe@linux.vnet.ibm.com>
    Reviewed-by: Bo Tu <tubo@linux.vnet.ibm.com>
    Message-id: 1460472980-26319-5-git-send-email-silbe@linux.vnet.ibm.com
    Reviewed-by: Max Reitz <mreitz@redhat.com>
    Signed-off-by: Max Reitz <mreitz@redhat.com>
    Sascha Silbe committed with XanClic Apr 12, 2016
  10. qemu-iotests: tests: do not set unused tmp variable

    The previous commit removed the last usage of ${tmp} inside the tests
    themselves; the only remaining users are sourced by check. So we can now
    drop this variable from the tests.
    
    Signed-off-by: Sascha Silbe <silbe@linux.vnet.ibm.com>
    Reviewed-by: Bo Tu <tubo@linux.vnet.ibm.com>
    Message-id: 1460472980-26319-4-git-send-email-silbe@linux.vnet.ibm.com
    Reviewed-by: Max Reitz <mreitz@redhat.com>
    Signed-off-by: Max Reitz <mreitz@redhat.com>
    Sascha Silbe committed with XanClic Apr 12, 2016
  11. qemu-iotests: common.rc: drop unused _do()

    _do() was never used and possibly creates temporary files at
    predictable, world-writable locations. Get rid of it.
    
    Signed-off-by: Sascha Silbe <silbe@linux.vnet.ibm.com>
    Reviewed-by: Bo Tu <tubo@linux.vnet.ibm.com>
    Message-id: 1460472980-26319-3-git-send-email-silbe@linux.vnet.ibm.com
    Reviewed-by: Max Reitz <mreitz@redhat.com>
    Signed-off-by: Max Reitz <mreitz@redhat.com>
    Sascha Silbe committed with XanClic Apr 12, 2016
  12. qemu-iotests: drop unused _within_tolerance() filter

    _within_tolerance() isn't used anymore and possibly creates temporary
    files at predictable, world-writable locations. Get rid of it.
    
    If it's needed again in the future it can be revived easily and fixed up
    to use TEST_DIR and / or safely created temporary files.
    
    Signed-off-by: Sascha Silbe <silbe@linux.vnet.ibm.com>
    Reviewed-by: Bo Tu <tubo@linux.vnet.ibm.com>
    Message-id: 1460472980-26319-2-git-send-email-silbe@linux.vnet.ibm.com
    Reviewed-by: Max Reitz <mreitz@redhat.com>
    Signed-off-by: Max Reitz <mreitz@redhat.com>
    Sascha Silbe committed with XanClic Apr 12, 2016
  13. hostmem-file: plug a small leak

    Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
    Message-Id: <1460566660-19241-1-git-send-email-marcandre.lureau@redhat.com>
    Reviewed-by: Igor Mammedov <imammedo@redhat.com>
    Signed-off-by: Markus Armbruster <armbru@redhat.com>
    elmarco committed with Markus Armbruster Apr 13, 2016
  14. Fix pflash migration

    Pflash migration (e.g. q35 + EFI variable storage) fails
    with the assert:
    
    bdrv_co_do_pwritev: Assertion `!(bs->open_flags & 0x0800)' failed.
    
    This avoids the problem by delaying the pflash update until after
    the device loads complete.
    
    Tested by:
      Migrating Q35/EFI vm.
      Changing efi variable content (with efiboot in the guest)
      md5sum'ing the variable file before migration and after.
    
    This is a fix that Paolo posted in the message
      570244B3.4070105@redhat.com
    
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
    Acked-by: Laszlo Ersek <lersek@redhat.com>
    Signed-off-by: Kevin Wolf <kwolf@redhat.com>
    dagrh committed with Kevin Wolf Apr 15, 2016
  15. block: Don't ignore flags in blk_{,co,aio}_write_zeroes()

    Commit 57d6a42 neglected to pass the given flags to blk_aio_prwv(),
    which broke discard by WRITE SAME for scsi-disk (the UNMAP bit would be
    ignored).
    
    Commit fc1453c introduced the same bug for blk_write_zeroes(). This is
    used for 'qemu-img convert' without has_zero_init (e.g. on a block
    device) and for preallocation=falloc in parallels.
    
    Commit 8896e08 is the version for blk_co_write_zeroes(). This function
    is only used in qemu-io.
    
    Reported-by: Max Reitz <mreitz@redhat.com>
    Signed-off-by: Kevin Wolf <kwolf@redhat.com>
    Reviewed-by: Eric Blake <eblake@redhat.com>
    Kevin Wolf committed Apr 15, 2016
  16. block/vpc: update comments to be compliant w/coding guidelines

    Signed-off-by: Jeff Cody <jcody@redhat.com>
    Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
    Signed-off-by: Kevin Wolf <kwolf@redhat.com>
    codyprime committed with Kevin Wolf Mar 23, 2016
  17. block/vpc: set errp in vpc_open

    Add more useful error information to failure paths in vpc_open
    
    Signed-off-by: Jeff Cody <jcody@redhat.com>
    Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
    Signed-off-by: Kevin Wolf <kwolf@redhat.com>
    codyprime committed with Kevin Wolf Mar 23, 2016
  18. block/vpc: make checks on max table size a bit more lax

    The check on the max_table_size field not being larger than required is
    valid, and in accordance with the VHD spec.  However, there have been
    VHD images encountered in the wild that have an out-of-spec max table
    size that is technically too large.
    
    There is no issue in allowing this larger table size, as we also
    later verify that the computed size (used for the pagetable) is
    large enough to fit all sectors.  In addition, max_table_entries
    is bounds checked against SIZE_MAX and INT_MAX.
    
    Remove the strict check, so that we can accomodate these sorts of
    images that are benignly out of spec.
    
    Reported-by: Stefan Hajnoczi <stefanha@redhat.com>
    Reported-by: Grant Wu <grantwwu@gmail.com>
    Signed-off-by: Jeff Cody <jcody@redhat.com>
    Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
    Signed-off-by: Kevin Wolf <kwolf@redhat.com>
    codyprime committed with Kevin Wolf Mar 23, 2016
  19. block/vpc: Use the correct max sector count for VHD images

    The old VHD_MAX_SECTORS value is incorrect, and is a throwback
    to the CHS calculations.  The VHD specification allows images up to 2040
    GiB, which (using 512 byte sectors) corresponds to a maximum number of
    sectors of 0xff000000, rather than the old value of 0xfe0001ff.
    
    Update VHD_MAX_SECTORS to reflect the correct value.
    
    Also, update comment references to the actual size limit, and correct
    one compare so that we can have sizes up to the limit.
    
    Signed-off-by: Jeff Cody <jcody@redhat.com>
    Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
    Signed-off-by: Kevin Wolf <kwolf@redhat.com>
    codyprime committed with Kevin Wolf Mar 23, 2016
  20. block/vpc: use current_size field for XenConverter VHD images

    XenConverter VHD images are another VHD image where current_size is
    different from the CHS values in the the format header.  Use
    current_size as the default, by looking at the creator_app signature
    field.
    
    Signed-off-by: Jeff Cody <jcody@redhat.com>
    Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
    Signed-off-by: Kevin Wolf <kwolf@redhat.com>
    codyprime committed with Kevin Wolf Mar 23, 2016
  21. vpc: use current_size field for XenServer VHD images

    The vpc driver has two methods of determining virtual disk size.  The
    correct one to use depends on the software that generated the image
    file.  Add the XenServer creator_app signature so that image size is
    correctly detected for those images.
    
    Reported-by: Grant Wu <grantwwu@gmail.com>
    Reported-by: Spencer Baugh <sbaugh@catern.com>
    Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
    Signed-off-by: Jeff Cody <jcody@redhat.com>
    Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
    Signed-off-by: Kevin Wolf <kwolf@redhat.com>
    Stefan Hajnoczi committed with Kevin Wolf Mar 23, 2016
  22. block/vpc: set errp in vpc_create

    Add more useful error information to failure paths in vpc_create().
    
    Signed-off-by: Jeff Cody <jcody@redhat.com>
    Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
    Signed-off-by: Kevin Wolf <kwolf@redhat.com>
    codyprime committed with Kevin Wolf Mar 23, 2016
  23. block: Fix blk_aio_write_zeroes()

    Commit 57d6a42 broke blk_aio_write_zeroes() because in some write
    functions in the call path don't have an explicit length argument but
    reuse qiov->size instead. Which is great, except that write_zeroes
    doesn't have a qiov, which this commit interprets as 0 bytes.
    Consequently, blk_aio_write_zeroes() didn't effectively do anything.
    
    This patch introduces an explicit acb->bytes in BlkAioEmAIOCB and uses
    that instead of acb->rwco.size.
    
    The synchronous version of the function is okay because it does pass a
    qiov (with the right size and a NULL pointer as its base).
    
    Signed-off-by: Kevin Wolf <kwolf@redhat.com>
    Reviewed-by: Max Reitz <mreitz@redhat.com>
    Kevin Wolf committed Apr 13, 2016