Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
branch: qom-cpu-sparc
Commits on Mar 20, 2015
  1. pc: Ensure non-zero CPU ref count after attaching to ICC bus

    authored
    Setting the parent bus of a device increases its ref count, which we
    ultimately want to level out. However it is only safe to do so after the
    last reference to the device in local code, as qom-set or similar operations
    might decrease the ref count.
    
    Therefore move the object_unref() from pc_new_cpu() into its callers.
    
    The APIC operations on the last CPU in pc_cpus_init() are still potentially
    insecure, but that is beyond the scope of this code movement.
    
    Signed-off-by: Andreas Färber <afaerber@suse.de>
  2. @pm215

    Merge remote-tracking branch 'remotes/ehabkost/tags/x86-pull-request'…

    pm215 authored
    … into staging
    
    X86 queue 2015-03-19
    
    # gpg: Signature made Thu Mar 19 19:40:17 2015 GMT using RSA key ID 984DC5A6
    # gpg: Good signature from "Eduardo Habkost <ehabkost@redhat.com>"
    # gpg: WARNING: This key is not certified with sufficiently trusted signatures!
    # gpg:          It is not certain that the signature belongs to the owner.
    # Primary key fingerprint: 5A32 2FD5 ABC4 D3DB ACCF  D1AA 2807 936F 984D C5A6
    
    * remotes/ehabkost/tags/x86-pull-request:
      target-i386: Haswell-noTSX and Broadwell-noTSX
      Revert "target-i386: Disable HLE and RTM on Haswell & Broadwell"
    
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
  3. @pm215

    Merge remote-tracking branch 'remotes/ehabkost/tags/work/numa-verify-…

    pm215 authored
    …cpus-pull-request' into staging
    
    NUMA queue 2015-03-19
    
    # gpg: Signature made Thu Mar 19 19:25:53 2015 GMT using RSA key ID 984DC5A6
    # gpg: Can't check signature: public key not found
    
    * remotes/ehabkost/tags/work/numa-verify-cpus-pull-request:
      numa: Print warning if no node is assigned to a CPU
      pc: fix default VCPU to NUMA node mapping
      numa: introduce machine callback for VCPU to node mapping
      numa: Reject configuration if CPU appears on multiple nodes
      numa: Reject CPU indexes > max_cpus
      numa: Fix off-by-one error at MAX_CPUMASK_BITS check
    
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
  4. @pm215

    Merge remote-tracking branch 'remotes/kraxel/tags/pull-usb-20150320-1…

    pm215 authored
    …' into staging
    
    usb: bugfix collection.
    
    # gpg: Signature made Fri Mar 20 07:51:19 2015 GMT using RSA key ID D3E87138
    # gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>"
    # gpg:                 aka "Gerd Hoffmann <gerd@kraxel.org>"
    # gpg:                 aka "Gerd Hoffmann (private) <kraxel@gmail.com>"
    
    * remotes/kraxel/tags/pull-usb-20150320-1:
      ehci: fix segfault when hot-unplugging ehci controller
      ohci: fix resource cleanup leak
      uhci: fix segfault when hot-unplugging uhci controller
      hw/usb: Include USB files only if necessary
      usb/dev-storage: Avoid qerror_report_err() outside QMP handlers
      usb/dev-storage: Fix QMP device_add missing encryption key failure
      monitor usb: Inline monitor_read_bdrv_key_start()'s first part
      monitor: Plug memory leak in monitor_read_bdrv_key_start()
      monitor: Drop dead QMP check from monitor_read_password()
      uhci: Convert to realize
      ohci: Complete conversion to realize
      usb: Improve companion configuration error messages
      usb: Propagate errors through usb_register_companion()
    
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
  5. @gongleiarei @kraxel

    ehci: fix segfault when hot-unplugging ehci controller

    gongleiarei authored kraxel committed
    When hot-unplugging the usb controllers (ehci/uhci),
    we have to clean all resouce of these devices,
    involved registered reset handler. Otherwise, it
    may cause NULL pointer access and/or segmentation fault
    if we reboot the guest os after hot-unplugging.
    
    Let's hook up reset via DeviceClass->reset() and drop
    the qemu_register_reset() call. Then Qemu will register
    and unregister the reset handler automatically.
    
    Cc: qemu-stable <qemu-stable@nongnu.org>
    Reported-by: Lidonglin <lidonglin@huawei.com>
    Signed-off-by: Gonglei <arei.gonglei@huawei.com>
    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
  6. @gongleiarei @kraxel

    ohci: fix resource cleanup leak

    gongleiarei authored kraxel committed
    When hot-unplugging the usb controllers (ehci/uhci),
    we have to clean all resouce of these devices,
    involved registered reset handler. Otherwise, it
    may cause NULL pointer access and/or segmentation fault
    if we reboot the guest os after hot-unplugging.
    
    Let's hook up reset via DeviceClass->reset() and drop
    the qemu_register_reset() call. Then Qemu will register
    and unregister the reset handler automatically.
    
    Ohci does't support hotplugging/hotunplugging yet, but
    existing resource cleanup leak logic likes ehci/uhci.
    
    Cc: qemu-stable <qemu-stable@nongnu.org>
    Signed-off-by: Gonglei <arei.gonglei@huawei.com>
    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
  7. @gongleiarei @kraxel

    uhci: fix segfault when hot-unplugging uhci controller

    gongleiarei authored kraxel committed
    When hot-unplugging the usb controllers (ehci/uhci),
    we have to clean all resouce of these devices,
    involved registered reset handler. Otherwise, it
    may cause NULL pointer access and/or segmentation fault
    if we reboot the guest os after hot-unplugging.
    
    Let's hook up reset via DeviceClass->reset() and drop
    the qemu_register_reset() call. Then Qemu will register
    and unregister the reset handler automatically.
    
    Cc: qemu-stable <qemu-stable@nongnu.org>
    Reported-by: Lidonglin <lidonglin@huawei.com>
    Signed-off-by: Gonglei <arei.gonglei@huawei.com>
    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Commits on Mar 19, 2015
  1. @ehabkost

    target-i386: Haswell-noTSX and Broadwell-noTSX

    ehabkost authored
    With the Intel microcode update that removed HLE and RTM, there will be
    different kinds of Haswell and Broadwell CPUs out there: some that still
    have the HLE and RTM features, and some that don't have the HLE and RTM
    features. On both cases people may be willing to use the pc-*-2.3
    machine-types.
    
    So, to cover both cases, introduce Haswell-noTSX and Broadwell-noTSX CPU
    models, for hosts that have Haswell and Broadwell CPUs without TSX support.
    
    Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
    Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
  2. @ehabkost

    Revert "target-i386: Disable HLE and RTM on Haswell & Broadwell"

    ehabkost authored
    This reverts commit 13704e4.
    
    With the Intel microcode update that removed HLE and RTM, there will be
    different kinds of Haswell and Broadwell CPUs out there: some that still
    have the HLE and RTM features, and some that don't have the HLE and RTM
    features. On both cases people may be willing to use the pc-*-2.3
    machine-types.
    
    So instead of making the CPU model results confusing by making it depend
    on the machine-type, keep HLE and RTM on the existing Haswell and
    Broadwell CPU models. The plan is to introduce "Haswell-noTSX" and
    "Broadwell-noTSX" CPU models later, for people who have CPUs that don't
    have TSX feature available.
    
    Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
    Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
  3. @ehabkost

    numa: Print warning if no node is assigned to a CPU

    ehabkost authored
    We need all possible CPUs (including hotplug ones) to be present in the
    SRAT when QEMU starts. QEMU already does that correctly today, the only
    problem is that when a CPU is omitted from the NUMA configuration, it is
    silently assigned to node 0.
    
    Check if all CPUs up to max_cpus are present in the NUMA configuration
    and warn about missing CPUs.
    
    Make it just a warning, to allow management software to be updated if
    necessary. In the future we may make it a fatal error instead.
    
    Command-line examples:
    
    * Correct, no warning:
    
      $ qemu-system-x86_64 -smp 2,maxcpus=4
      $ qemu-system-x86_64 -smp 2,maxcpus=4 -numa node,cpus=0-3
    
    * Incomplete, with warnings:
    
      $ qemu-system-x86_64 -smp 2,maxcpus=4 -numa node,cpus=0
      qemu-system-x86_64: warning: CPU(s) not present in any NUMA nodes: 1 2 3
      qemu-system-x86_64: warning: All CPU(s) up to maxcpus should be described in NUMA config
    
      $ qemu-system-x86_64 -smp 2,maxcpus=4 -numa node,cpus=0-2
      qemu-system-x86_64: warning: CPU(s) not present in any NUMA nodes: 3
      qemu-system-x86_64: warning: All CPU(s) up to maxcpus should be described in NUMA config
    
    Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
    ---
    v1 -> v2: (no changes)
    
    v2 -> v3:
     * Use enumerate_cpus() and error_report() for error message
     * Simplify logic using bitmap_full()
    
    v3 -> v4:
     * Clarify error message, mention that all CPUs up to
       maxcpus need to be described in NUMA config
    
    v4 -> v5:
     * Commit log update, to make problem description clearer
  4. @ehabkost

    pc: fix default VCPU to NUMA node mapping

    Igor Mammedov authored ehabkost committed
    Since commit
       dd0247e pc: acpi: mark all possible CPUs as enabled in SRAT
    Linux kernel actually tries to use CPU to Node mapping from
    QEMU provided SRAT table instead of discarding it, and that
    in some cases breaks build_sched_domains() which expects
    sane mapping where cores/threads belonging to the same socket
    are on the same NUMA node.
    
    With current default round-robin mapping of VCPUs to nodes
    guest ends-up with cores/threads belonging to the same socket
    being on different NUMA nodes.
    
    For example with following CLI:
    
       qemu-system-x86_64 -m 4G \
             -cpu Opteron_G3,vendor=AuthenticAMD \
             -smp 5,sockets=1,cores=4,threads=1,maxcpus=8 \
             -numa node,nodeid=0 -numa node,nodeid=1
    
    2.6.32 based kernels will hang on boot due to incorrectly built
    sched_group-s list in update_sd_lb_stats()
    
    Replacing default mapping with a manual, where VCPUs belonging to
    the same socket are on the same NUMA node, fixes the issue for
    guests which can't handle nonsense topology i.e. changing CLI to:
      -numa node,nodeid=0,cpus=0-3 -numa node,nodeid=1,cpus=4-7
    
    So instead of simply scattering VCPUs around nodes, provide
    callback to map the same socket VCPUs to the same NUMA node,
    which is what guests would expect from a sane hardware/BIOS.
    
    Signed-off-by: Igor Mammedov <imammedo@redhat.com>
    Reviewed-by: Andreas Färber <afaerber@suse.de>
    Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
  5. @ehabkost

    numa: introduce machine callback for VCPU to node mapping

    Igor Mammedov authored ehabkost committed
    Current default round-robin way of distributing VCPUs among
    NUMA nodes might be wrong in case on multi-core/threads
    CPUs. Making guests confused wrt topology where cores from
    the same socket are on different nodes.
    
    Allow a machine to override default mapping by providing
     MachineClass::cpu_index_to_socket_id()
    callback which would allow it group VCPUs from a socket
    on the same NUMA node.
    
    Signed-off-by: Igor Mammedov <imammedo@redhat.com>
    Reviewed-by: Andreas Färber <afaerber@suse.de>
    Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
  6. @ehabkost

    numa: Reject configuration if CPU appears on multiple nodes

    ehabkost authored
    Each CPU can appear in only one NUMA node on the NUMA config. Reject
    configuration if a CPU appears in multiple nodes.
    
    Reviewed-by: Igor Mammedov <imammedo@redhat.com>
    Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
  7. @ehabkost

    numa: Reject CPU indexes > max_cpus

    ehabkost authored
    CPU index is always less than max_cpus, as documented at sysemu.h:
    
    > The following shall be true for all CPUs:
    >   cpu->cpu_index < max_cpus <= MAX_CPUMASK_BITS
    
    Reject configuration which uses invalid CPU indexes.
    
    Reviewed-by: Igor Mammedov <imammedo@redhat.com>
    Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
  8. @ehabkost

    numa: Fix off-by-one error at MAX_CPUMASK_BITS check

    ehabkost authored
    Fix the CPU index check to ensure we don't go beyond the size of the
    node_cpu bitmap.
    
    CPU index is always less than MAX_CPUMASK_BITS, as documented at
    sysemu.h:
    
    > The following shall be true for all CPUs:
    >   cpu->cpu_index < max_cpus <= MAX_CPUMASK_BITS
    
    Reviewed-by: Igor Mammedov <imammedo@redhat.com>
    Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
  9. @pm215

    Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into s…

    pm215 authored
    …taging
    
    Block patches for 2.3.0-rc1
    
    # gpg: Signature made Thu Mar 19 15:03:26 2015 GMT using RSA key ID C88F2FD6
    # gpg: Good signature from "Kevin Wolf <kwolf@redhat.com>"
    
    * remotes/kevin/tags/for-upstream:
      block: Fix blockdev-backup not to use funky error class
      raw-posix: Deprecate aio=threads fallback without O_DIRECT
      raw-posix: Deprecate host floppy passthrough
    
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
  10. @pm215

    Merge remote-tracking branch 'remotes/amit/tags/vser-for-2.3-3' into …

    pm215 authored
    …staging
    
    virtio-serial api: guest_writable callback for users
    
    # gpg: Signature made Thu Mar 19 12:06:55 2015 GMT using RSA key ID 854083B6
    # gpg: Good signature from "Amit Shah <amit@amitshah.net>"
    # gpg:                 aka "Amit Shah <amit@kernel.org>"
    # gpg:                 aka "Amit Shah <amitshah@gmx.net>"
    
    * remotes/amit/tags/vser-for-2.3-3:
      virtio: serial: expose a 'guest_writable' callback for users
    
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
  11. block: Fix blockdev-backup not to use funky error class

    Markus Armbruster authored Kevin Wolf committed
    Error classes are a leftover from the days of "rich" error objects.
    New code should always use ERROR_CLASS_GENERIC_ERROR.  Commit
    b7b9d39..7c6a4ab added uses of ERROR_CLASS_DEVICE_NOT_FOUND.  Replace
    them.
    
    Signed-off-by: Markus Armbruster <armbru@redhat.com>
    Reviewed-by: Eric Blake <eblake@redhat.com>
    Signed-off-by: Kevin Wolf <kwolf@redhat.com>
  12. @pm215

    Merge remote-tracking branch 'remotes/mjt/tags/pull-trivial-patches-2…

    pm215 authored
    …015-03-19' into staging
    
    trivial patches for 2015-03-19
    
    # gpg: Signature made Thu Mar 19 08:57:54 2015 GMT using RSA key ID A4C3D7DB
    # gpg: Good signature from "Michael Tokarev <mjt@tls.msk.ru>"
    # gpg:                 aka "Michael Tokarev <mjt@corpit.ru>"
    # gpg:                 aka "Michael Tokarev <mjt@debian.org>"
    
    * remotes/mjt/tags/pull-trivial-patches-2015-03-19: (24 commits)
      qga/commands-posix: Fix resource leak
      elf-loader: Add missing error handling for call of lseek
      elf-loader: Fix truncation warning from coverity
      hmp: Fix texinfo documentation
      Fix typos in comments
      qtest/ahci: Fix a bit mask expression
      vl: fix resource leak with monitor_fdset_add_fd
      smbios: add max speed comdline option for type-17 (meory device) structure
      pc-dimm: Add description for device list.
      configure: enable kvm on x32
      error: Replace error_report() & error_free() with error_report_err()
      arm: fix memory leak
      qmp: Drop unused .user_print from command definitions
      hmp: Fix definition of command quit
      target-moxie: Fix warnings from Sparse (one-bit signed bitfield)
      block/qapi: Fix Sparse warning
      Fix remaining warnings from Sparse (void return)
      qom: Fix warning from Sparse
      target-mips: Fix warning from Sparse
      arm/nseries: Fix warnings from Sparse
      ...
    
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
  13. @pm215

    Merge remote-tracking branch 'remotes/lalrae/tags/mips-20150318' into…

    pm215 authored
    … staging
    
    MIPS patches 2015-03-18
    
    Changes:
    * bug fixes
    
    # gpg: Signature made Wed Mar 18 10:06:00 2015 GMT using RSA key ID 0B29DA6B
    # gpg: Can't check signature: public key not found
    
    * remotes/lalrae/tags/mips-20150318:
      target-mips: save cpu state before calling MSA load and store helpers
      target-mips: fix hflags modified in delay / forbidden slot
      target-mips: fix CP0.BadVAddr by stopping translation on Address Error
    
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
  14. @pm215

    Merge remote-tracking branch 'remotes/kraxel/tags/pull-vnc-20150318-1…

    pm215 authored
    …' into staging
    
    vnc: fix websockets & QMP.
    
    # gpg: Signature made Wed Mar 18 13:12:35 2015 GMT using RSA key ID D3E87138
    # gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>"
    # gpg:                 aka "Gerd Hoffmann <gerd@kraxel.org>"
    # gpg:                 aka "Gerd Hoffmann (private) <kraxel@gmail.com>"
    
    * remotes/kraxel/tags/pull-vnc-20150318-1:
      ui: ensure VNC websockets server checks the ACL if requested
      ui: remove separate gnutls_session for websockets server
      ui: enforce TLS when using websockets server
      ui: fix setup of VNC websockets auth scheme with TLS
      ui: split setup of VNC auth scheme into separate method
      ui: report error if user requests VNC option that is unsupported
      ui: replace printf() calls with VNC_DEBUG
      ui: remove unused 'wiremode' variable in VncState struct
      vnc: Fix QMP change not to use funky error class
    
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
  15. virtio: serial: expose a 'guest_writable' callback for users

    Amit Shah authored
    Users of virtio-serial may want to know when a port becomes writable.  A
    port can stop accepting writes if the guest port is open but not being
    read from.  In this case, data gets queued up in the virtqueue, and
    after the vq is full, writes to the port do not succeed.
    
    When the guest reads off a vq element, and adds a new one for the host
    to put data in, we can tell users the port is available for more writes,
    via the new ->guest_writable() callback.
    
    Reviewed-by: Markus Armbruster <armbru@redhat.com>
    Signed-off-by: Amit Shah <amit.shah@redhat.com>
  16. raw-posix: Deprecate aio=threads fallback without O_DIRECT

    Kevin Wolf authored
    Currently, if the user requests aio=native, but forgets to choose a
    cache mode that sets O_DIRECT, that request is silently ignored and raw
    falls back to aio=threads.
    
    Deprecate that behaviour so we can make it an error in future qemu
    versions.
    
    Signed-off-by: Kevin Wolf <kwolf@redhat.com>
    Reviewed-by: Markus Armbruster <armbru@redhat.com>
  17. @pm215

    Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into sta…

    pm215 authored
    …ging
    
    pci, virtio bugfixes for 2.3
    
    Just a bunch of bugfixes. Should be nothing remarkable here.
    
    Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    
    # gpg: Signature made Wed Mar 18 12:31:03 2015 GMT using RSA key ID D28D5469
    # gpg: Good signature from "Michael S. Tsirkin <mst@kernel.org>"
    # gpg:                 aka "Michael S. Tsirkin <mst@redhat.com>"
    # gpg: WARNING: This key is not certified with a trusted signature!
    # gpg:          There is no indication that the signature belongs to the owner.
    # Primary key fingerprint: 0270 606B 6F3C DF3D 0B17  0970 C350 3912 AFBE 8E67
    #      Subkey fingerprint: 5D09 FD08 71C8 F85B 94CA  8A0D 281F 0DB8 D28D 5469
    
    * remotes/mst/tags/for_upstream:
      pcie_aer: fix comment to match pcie spec
      pci: fix several trivial typos in comment
      aer: fix a wrong init PCI_ERR_COR_STATUS w1cmask type register
      pcie_aer: fix typos in pcie_aer_inject_error comment
      aer: fix wrong check on expose aer tlp prefix log
      pcie: correct mistaken register bit for End-End TLP Prefix Blocking
      virtio: Fix memory leaks reported by Coverity
      virtio: validate the existence of handle_output before calling it
    
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
  18. raw-posix: Deprecate host floppy passthrough

    Markus Armbruster authored Kevin Wolf committed
    Raise your hand if you have a physical floppy drive in a computer
    you've powered on in 2015.  Okay, I see we got a few weirdos in the
    audience.  That's okay, weirdos are welcome here.
    
    Kidding aside, media change detection doesn't fully work, isn't going
    to be fixed, and floppy passthrough just isn't earning its keep
    anymore.
    
    Deprecate block driver host_floppy now, so we can drop it after a
    grace period.
    
    Signed-off-by: Markus Armbruster <armbru@redhat.com>
    Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
    Reviewed-by: Eric Blake <eblake@redhat.com>
    Reviewed-by: Max Reitz <mreitz@redhat.com>
    Signed-off-by: Kevin Wolf <kwolf@redhat.com>
  19. @pm215

    Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into…

    pm215 authored
    … staging
    
    - kvm: ioeventfd fix for PPC64LE
    - virtio-scsi: misc fixes
    - fix for --enable-profiler
    - nbd: fixes from Max
    - build: fix for scripts/make_device_config.sh
    - exec: fix for address_space_translate
    
    # gpg: Signature made Wed Mar 18 11:11:08 2015 GMT using RSA key ID 78C7AE83
    # gpg: Good signature from "Paolo Bonzini <bonzini@gnu.org>"
    # gpg:                 aka "Paolo Bonzini <pbonzini@redhat.com>"
    # gpg: WARNING: This key is not certified with a trusted signature!
    # gpg:          There is no indication that the signature belongs to the owner.
    # Primary key fingerprint: 46F5 9FBD 57D6 12E7 BFD4  E2F7 7E15 100C CD36 69B1
    #      Subkey fingerprint: F133 3857 4B66 2389 866C  7682 BFFB D25F 78C7 AE83
    
    * remotes/bonzini/tags/for-upstream:
      exec: Respect as_tranlsate_internal length clamp
      virtio-scsi-dataplane: fix memory leak in virtio_scsi_vring_init
      profiler: Reenable built-in profiler
      kvm: fix ioeventfd endianness on bi-endian architectures
      virtio-scsi: Fix assert in virtio_scsi_push_event
      build: pass .d file name to scripts/make_device_config.sh, fix makefile target
      coroutine-io: Return -errno in case of error
      nbd: Drop unexpected data for NBD_OPT_LIST
      nbd: Fix interpretation of the export flags
      nbd: Fix nbd_receive_options()
      nbd: Set block size to BDRV_SECTOR_SIZE
      nbd: Fix potential signed overflow issues
      qemu-nbd: fork() can fail
      nbd: Handle blk_getlength() failure
      nbd: Pass return value from nbd_handle_list()
      nbd: Fix nbd_establish_connection()'s return value
      qemu-nbd: Detect unused partitions by system == 0
      util/uri: Add overflow check to rfc3986_parse_port
      nbd: Fix overflow return value
    
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
  20. qga/commands-posix: Fix resource leak

    Shannon Zhao authored Michael Tokarev committed
    It's detected by coverity. Close the dirfd.
    
    Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
    Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
    Reviewed-by: Stefan Weil <sw@weilnetz.de>
    Reviewed-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
    Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
  21. @stweil

    elf-loader: Add missing error handling for call of lseek

    stweil authored Michael Tokarev committed
    This fixes a warning from Coverity.
    
    Signed-off-by: Stefan Weil <sw@weilnetz.de>
    Reviewed-by: Thomas Huth <thuth@linux.vnet.ibm.com>
    Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
  22. @stweil

    elf-loader: Fix truncation warning from coverity

    stweil authored Michael Tokarev committed
    Coverity reports a truncation due to cast operation on operand
    reltab->sh_size from 64 bits to 32 bits for calls of load_at.
    
    Fix the types of the function arguments to match their use in
    function load_at: the offset is used for lseek which takes an
    off_t parameter, the size is used for g_malloc and read.
    
    Signed-off-by: Stefan Weil <sw@weilnetz.de>
    Reviewed-by: Thomas Huth <thuth@linux.vnet.ibm.com>
    Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
  23. hmp: Fix texinfo documentation

    Markus Armbruster authored Michael Tokarev committed
    Several issues:
    
    * Commands i and o lack @item.  Their one-liner documentation gets
      squashed into the preceding command print.  Add the obvious @item.
    
    * Commands i, o and cpu-add lack @findex.  The function index doesn't
      have them.  Add the obvious @findex.
    
    * Commit 727f005 put block_set_io_throttle was added in the middle of
      block_passwd.  Move it.
    
    * Correct spelling of commands chardev-add and chardev-remove in @item
      and @findex.
    
    * Some commands have a blank line between @item/@findex and the text,
      most don't.  Normalize to no blank line.
    
    Signed-off-by: Markus Armbruster <armbru@redhat.com>
    Reviewed-by: Eric Blake <eblake@redhat.com>
    Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
  24. @visweshn92

    Fix typos in comments

    visweshn92 authored Michael Tokarev committed
    Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
    Signed-off-by: Viswesh <visweshn92@gmail.com>
    Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
  25. @jnsnow

    qtest/ahci: Fix a bit mask expression

    jnsnow authored Michael Tokarev committed
    A thinko that clang 3.5.0 caught.
    Thankfully does not introduce any new failures.
    
    Signed-off-by: John Snow <jsnow@redhat.com>
    Reviewed-by: Markus Armbruster <armbru@redhat.com>
    Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
  26. @bonzini

    vl: fix resource leak with monitor_fdset_add_fd

    bonzini authored Michael Tokarev committed
    monitor_fdset_add_fd returns an AddfdInfo struct (used by the QMP
    command add_fd).  Free it.
    
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
    Reviewed-by: Fam Zheng <famz@redhat.com>
    Reviewed-by: Markus Armbruster <armbru@redhat.com>
    Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
  27. @gsomlo

    smbios: add max speed comdline option for type-17 (meory device) stru…

    gsomlo authored Michael Tokarev committed
    …cture
    
    Signed-off-by: Gabriel Somlo <somlo@cmu.edu>
    Acked-by: Paolo Bonzini <pbonzini@redhat.com>
    Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
  28. @pvital

    pc-dimm: Add description for device list.

    pvital authored Michael Tokarev committed
    The pc-dimm option presented on device list (by argument "-device \?")
    is the unique option that don't have any information about it. This
    patch adds a description for the pc-dimm device to help users to
    identify it.
    
    Signed-off-by: Paulo Vital <paulo.vital@profitbricks.com>
    Reviewed-by: Igor Mammedov <imammedo@redhat.com>
    Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
Something went wrong with that request. Please try again.