Skip to content
Commits on Mar 1, 2016
  1. MAINTAINERS: Drop target-i386 from CPU subsystem

    X86CPU QOM type is in good hands and actively maintained these days, so
    drop it from the generic QOM CPU subsystem.
    
    Some refactorings and design questions will still intersect, but review
    and discussions of individual series can still take place while opting out
    of general X86CPU patch review.
    
    Cc: Eduardo Habkost <ehabkost@redhat.com>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
    committed Feb 12, 2016
  2. @pm215

    Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20160301' int…

    …o staging
    
    Assorted fixes, cleanups and enhancements.
    
    # gpg: Signature made Tue 01 Mar 2016 11:45:12 GMT using RSA key ID C6F02FAF
    # gpg: Good signature from "Cornelia Huck <huckc@linux.vnet.ibm.com>"
    # gpg:                 aka "Cornelia Huck <cornelia.huck@de.ibm.com>"
    
    * remotes/cohuck/tags/s390x-20160301:
      s390x/css: only suspend when enabled by orb
      MAINTAINERS: Remove entry for hw/s390x/s390-virtio-bus.[ch]
      MAINTAINERS: Remove the old s390-virtio machine
      s390x/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries
      s390x/css: Use static initialization for channel_subsys fields
      s390x/css: Allocate channel_subsys statically
      s390x/pci: fix reg/dereg irq functions
      s390x/css: introduce indicator refcounting interfaces
      s390x/virtio: old machine leftovers
      watchdog/diag288: avoid race condition on expired watchdog
      s390x: remove {kvm_}s390_virtio_irq()
      s390x: fix debug statement in trigger_page_fault()
      s390x/kvm: sync fprs via kvm_run
      linux-headers: update against kvm/next
    
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
    pm215 committed Mar 1, 2016
  3. @pm215

    Merge remote-tracking branch 'remotes/kraxel/tags/pull-seabios-201603…

    …01-1' into staging
    
    seabios: update to 1.9.1 stable release
    
    # gpg: Signature made Tue 01 Mar 2016 08:39:53 GMT using RSA key ID D3E87138
    # gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>"
    # gpg:                 aka "Gerd Hoffmann <gerd@kraxel.org>"
    # gpg:                 aka "Gerd Hoffmann (private) <kraxel@gmail.com>"
    
    * remotes/kraxel/tags/pull-seabios-20160301-1:
      seabios: update to 1.9.1 stable release
    
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
    pm215 committed Mar 1, 2016
  4. @cohuck

    s390x/css: only suspend when enabled by orb

    We must not allow a channel program to suspend if the suspend
    control bit in the orb had not been specified.
    
    Reviewed-by: Halil Pasic <pasic@linux.vnet.ibm.com>
    Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
    cohuck committed Feb 22, 2016
  5. @huth @cohuck

    MAINTAINERS: Remove entry for hw/s390x/s390-virtio-bus.[ch]

    The files have been deleted recently, no need to keep these entries
    anymore.
    
    Signed-off-by: Thomas Huth <thuth@redhat.com>
    Message-Id: <1456397100-22746-1-git-send-email-thuth@redhat.com>
    Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
    huth committed with cohuck Feb 25, 2016
  6. @huth @cohuck

    MAINTAINERS: Remove the old s390-virtio machine

    The old s390-virtio machine has been removed last year, so we don't
    need the corresponding section in the MAINTAINERS file anymore.
    
    Signed-off-by: Thomas Huth <thuth@redhat.com>
    Message-Id: <1456394274-21082-1-git-send-email-thuth@redhat.com>
    Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
    huth committed with cohuck Feb 25, 2016
  7. @RichardWeiYang @cohuck

    s390x/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries

    Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is
    the more proper on retrieving MSIX entries.
    
    This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries.
    
    Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
    CC: Cornelia Huck <cornelia.huck@de.ibm.com>
    CC: Christian Borntraeger <borntraeger@de.ibm.com>
    Message-Id: <1455895091-7589-3-git-send-email-richard.weiyang@gmail.com>
    Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
    RichardWeiYang committed with cohuck Feb 19, 2016
  8. @ehabkost @cohuck

    s390x/css: Use static initialization for channel_subsys fields

    machine_init() will be gone, but we don't need it if we just
    initialize the channel_subsys fields statically.
    
    Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
    Cc: Christian Borntraeger <borntraeger@de.ibm.com>
    Cc: Richard Henderson <rth@twiddle.net>
    Cc: Alexander Graf <agraf@suse.de>
    Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
    Message-Id: <1455656347-29033-4-git-send-email-ehabkost@redhat.com>
    Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
    [adapted on top of indicator changes]
    Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
    ehabkost committed with cohuck Feb 16, 2016
  9. @ehabkost @cohuck

    s390x/css: Allocate channel_subsys statically

    There's no need to use g_malloc0() to allocate the channel_subsys
    struct, just use a static variable.
    
    Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
    Cc: Christian Borntraeger <borntraeger@de.ibm.com>
    Cc: Richard Henderson <rth@twiddle.net>
    Cc: Alexander Graf <agraf@suse.de>
    Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
    Message-Id: <1455656347-29033-3-git-send-email-ehabkost@redhat.com>
    Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
    [adapted on top of indicator changes]
    Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
    ehabkost committed with cohuck Feb 16, 2016
  10. @cohuck

    s390x/pci: fix reg/dereg irq functions

    Indicator refcounting interfaces are introduced. This patch fixes
    introducing unneeded indicator mappings and failure to release
    AISB mappings on deregistration.
    
    Signed-off-by: Yi Min Zhao <zyimin@linux.vnet.ibm.com>
    Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
    Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
    Yi Min Zhao committed with cohuck Jan 28, 2016
  11. @cohuck

    s390x/css: introduce indicator refcounting interfaces

    Currently, virtio-ccw uses its own interfaces to keep indicators mapped
    just once even if the same address has been registered multiple times.
    These interfaces fit the PCI use case as well. Therefore, move them to
    css and make them generic interfaces.
    
    Signed-off-by: Yi Min Zhao <zyimin@linux.vnet.ibm.com>
    Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
    Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
    Yi Min Zhao committed with cohuck Jan 27, 2016
  12. @cohuck

    s390x/virtio: old machine leftovers

    Remove some now unused #defines.
    
    Reviewed-By: Sascha Silbe <silbe@linux.vnet.ibm.com>
    Reviewed-by: Halil Pasic <pasic@linux.vnet.ibm.com>
    Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
    cohuck committed Feb 10, 2016
  13. @cohuck

    watchdog/diag288: avoid race condition on expired watchdog

    When configured to inject an NMI, watchdog_perform_action() may cause
    the BQL to be temporarily relinquished (inject_nmi() → ... →
    s390_nmi() → s390_cpu_restart() → run_on_cpu()). When the guest issues
    diag 288 again in response to the NMI, the diag 288 operation will
    race against wdt_diag288_reset(). Depending on scheduler behaviour,
    wdt_diag288_reset() may be run after the guest issued a diag 288
    Init. As a result, we will cancel the timer the guest just set up. The
    effect observed by the guest is that a second expiry does not trigger
    the watchdog action and diag 288 Change operations fail.
    
    Fix this by resetting the timer _before_ invoking the action.
    
    Signed-off-by: Sascha Silbe <silbe@linux.vnet.ibm.com>
    Acked-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
    Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
    Sascha Silbe committed with cohuck Jan 29, 2016
  14. @cohuck

    s390x: remove {kvm_}s390_virtio_irq()

    This interface was only used by the old virtio machine and therefore
    is not needed anymore.
    
    Reviewed-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
    Reviewed-by: Halil Pasic <pasic@linux.vnet.ibm.com>
    Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
    cohuck committed Jan 27, 2016
  15. @cohuck

    s390x: fix debug statement in trigger_page_fault()

    When mmu_translate debugging output is enabled, code won't compile.
    Let's just use the same statement as in trigger_prot_fault().
    
    Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
    Signed-off-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
    Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
    David Hildenbrand committed with cohuck Jan 25, 2016
  16. @cohuck

    s390x/kvm: sync fprs via kvm_run

    We can now also sync the fprs via kvm_run, avoiding one ioctl.
    
    Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
    Signed-off-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
    Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
    David Hildenbrand committed with cohuck Feb 2, 2016
  17. @cohuck

    linux-headers: update against kvm/next

    Update against commit efef127c, but keep userfaultd.h.
    
    Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
    cohuck committed Feb 22, 2016
  18. @pm215

    Merge remote-tracking branch 'remotes/kraxel/tags/pull-input-20160301…

    …-1' into staging
    
    qapi: fix input-send-event and promote to stable
    
    # gpg: Signature made Tue 01 Mar 2016 08:19:52 GMT using RSA key ID D3E87138
    # gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>"
    # gpg:                 aka "Gerd Hoffmann <gerd@kraxel.org>"
    # gpg:                 aka "Gerd Hoffmann (private) <kraxel@gmail.com>"
    
    * remotes/kraxel/tags/pull-input-20160301-1:
      qapi: promote input-send-event to stable
      qapi: rename InputAxis values.
      qapi: rename input buttons
      qapi: switch x-input-send-event from console to device+head
      console: add & use qemu_console_lookup_by_device_name
    
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
    pm215 committed Mar 1, 2016
  19. @pm215

    Merge remote-tracking branch 'remotes/kraxel/tags/pull-vga-20160301-1…

    …' into staging
    
    vga: minor cirrus/qxl bugfixes.
    
    # gpg: Signature made Tue 01 Mar 2016 07:16:22 GMT using RSA key ID D3E87138
    # gpg: Good signature from "Gerd Hoffmann (work) <kraxel@redhat.com>"
    # gpg:                 aka "Gerd Hoffmann <gerd@kraxel.org>"
    # gpg:                 aka "Gerd Hoffmann (private) <kraxel@gmail.com>"
    
    * remotes/kraxel/tags/pull-vga-20160301-1:
      qxl: lock current_async update in qxl_soft_reset
      cirrus_vga: fix off-by-one in blit_region_is_unsafe
    
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
    pm215 committed Mar 1, 2016
  20. @pm215

    Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' i…

    …nto staging
    
    # gpg: Signature made Mon 29 Feb 2016 20:08:16 GMT using RSA key ID C0DE3057
    # gpg: Good signature from "Jeffrey Cody <jcody@redhat.com>"
    # gpg:                 aka "Jeffrey Cody <jeff@codyprime.org>"
    # gpg:                 aka "Jeffrey Cody <codyprime@gmail.com>"
    
    * remotes/cody/tags/block-pull-request:
      iotests/124: Add cluster_size mismatch test
      block/backup: avoid copying less than full target clusters
      block/backup: make backup cluster size configurable
      mirror: Add mirror_wait_for_io
      mirror: Rewrite mirror_iteration
      vhdx: Simplify vhdx_set_shift_bits()
      vhdx: DIV_ROUND_UP() in vhdx_calc_bat_entries()
      iscsi: add support for getting CHAP password via QCryptoSecret API
      curl: add support for HTTP authentication parameters
      rbd: add support for getting password from QCryptoSecret object
      sheepdog: allow to delete snapshot
      block/nfs: add support for setting debug level
    
    Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
    pm215 committed Mar 1, 2016
  21. @kraxel

    seabios: update to 1.9.1 stable release

    git shortlog rel-1.9.0..rel-1.9.1
    =================================
    
    Cole Robinson (1):
          biostables: Support SMBIOS 2.6+ UUID format
    
    Kevin O'Connor (7):
          xhci: Check for device disconnects during USB2 reset polling
          xhci: Wait for port enable even for USB3 devices
          sdcard: Only enable error_irq_enable for bits defined in SDHCI v1 spec
          sdcard: fix typo causing 32bit write to 16bit block_size field
          nmi: Don't try to switch onto extra stack in NMI handler
          scsi: Do not call printf() from scsi_is_ready()
          coreboot: Check for unaligned cbfs header
    
    Marcel Apfelbaum (1):
          fw/pci: do not automatically allocate IO region for PCIe bridges
    
    Roger Pau Monne (1):
          build: fix typo in buildversion.py
    
    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
    kraxel committed Mar 1, 2016
  22. @kraxel

    qapi: promote input-send-event to stable

    With all fixups being in place now, we can promote input-send-event
    to stable abi by removing the x- prefix.
    
    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
    Reviewed-by: Markus Armbruster <armbru@redhat.com>
    Reviewed-by: Eric Blake <eblake@redhat.com>
    kraxel committed Jan 12, 2016
  23. @kraxel

    qapi: rename InputAxis values.

    Lowercase them.
    
    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
    Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
    Reviewed-by: Markus Armbruster <armbru@redhat.com>
    Reviewed-by: Eric Blake <eblake@redhat.com>
    kraxel committed Jan 12, 2016
  24. @kraxel

    qapi: rename input buttons

    All lowercase, use-dash instead of CamelCase.
    
    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
    Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
    Reviewed-by: Markus Armbruster <armbru@redhat.com>
    Reviewed-by: Eric Blake <eblake@redhat.com>
    kraxel committed Jan 12, 2016
  25. @kraxel

    qapi: switch x-input-send-event from console to device+head

    Use display device qdev id and head number instead of console index to
    specify the QemuConsole.  This makes things consistent with input
    devices (for input routing) and vnc server configuration, which both use
    display and head too.
    
    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
    Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
    Reviewed-by: Markus Armbruster <armbru@redhat.com>
    kraxel committed Jan 12, 2016
  26. @kraxel

    console: add & use qemu_console_lookup_by_device_name

    We have two places needing this, and a third one will come shortly.
    So factor things out into a helper function to reduce code duplication.
    
    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
    Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
    Reviewed-by: Markus Armbruster <armbru@redhat.com>
    kraxel committed Jan 12, 2016
  27. @kraxel

    qxl: lock current_async update in qxl_soft_reset

    This should fix a defect report from Coverity.
    
    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
    Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
    kraxel committed Oct 20, 2015
  28. @bonzini @kraxel

    cirrus_vga: fix off-by-one in blit_region_is_unsafe

    The "max" value is being compared with >=, but addr + width points to
    the first byte that will _not_ be copied.  Laszlo suggested using a
    "greater than" comparison, instead of subtracting one like it is
    already done above for the height, so that max remains always positive.
    
    The mistake is "safe"---it will reject some blits, but will never cause
    out-of-bounds writes.
    
    Cc: Gerd Hoffmann <kraxel@redhat.com>
    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
    Reviewed-by: Laszlo Ersek <lersek@redhat.com>
    Message-id: 1455121059-18280-1-git-send-email-pbonzini@redhat.com
    Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
    bonzini committed with kraxel Feb 10, 2016
Commits on Feb 29, 2016
  1. @jnsnow @codyprime

    iotests/124: Add cluster_size mismatch test

    If a backing file isn't specified in the target image and the
    cluster_size is larger than the bitmap granularity, we run the risk of
    creating bitmaps with allocated clusters but empty/no data which will
    prevent the proper reading of the backup in the future.
    
    Signed-off-by: John Snow <jsnow@redhat.com>
    Reviewed-by: Fam Zheng <famz@redhat.com>
    Message-id: 1456433911-24718-4-git-send-email-jsnow@redhat.com
    Signed-off-by: Jeff Cody <jcody@redhat.com>
    jnsnow committed with codyprime Feb 25, 2016
  2. @jnsnow @codyprime

    block/backup: avoid copying less than full target clusters

    During incremental backups, if the target has a cluster size that is
    larger than the backup cluster size and we are backing up to a target
    that cannot (for whichever reason) pull clusters up from a backing image,
    we may inadvertantly create unusable incremental backup images.
    
    For example:
    
    If the bitmap tracks changes at a 64KB granularity and we transmit 64KB
    of data at a time but the target uses a 128KB cluster size, it is
    possible that only half of a target cluster will be recognized as dirty
    by the backup block job. When the cluster is allocated on the target
    image but only half populated with data, we lose the ability to
    distinguish between zero padding and uninitialized data.
    
    This does not happen if the target image has a backing file that points
    to the last known good backup.
    
    Even if we have a backing file, though, it's likely going to be faster
    to just buffer the redundant data ourselves from the live image than
    fetching it from the backing file, so let's just always round up to the
    target granularity.
    
    The same logic applies to backup modes top, none, and full. Copying
    fractional clusters without the guarantee of COW is dangerous, but even
    if we can rely on COW, it's likely better to just re-copy the data.
    
    Reported-by: Fam Zheng <famz@redhat.com>
    Signed-off-by: John Snow <jsnow@redhat.com>
    Reviewed-by: Fam Zheng <famz@redhat.com>
    Message-id: 1456433911-24718-3-git-send-email-jsnow@redhat.com
    Signed-off-by: Jeff Cody <jcody@redhat.com>
    jnsnow committed with codyprime Feb 25, 2016
  3. @jnsnow @codyprime

    block/backup: make backup cluster size configurable

    64K might not always be appropriate, make this a runtime value.
    
    Signed-off-by: John Snow <jsnow@redhat.com>
    Reviewed-by: Fam Zheng <famz@redhat.com>
    Message-id: 1456433911-24718-2-git-send-email-jsnow@redhat.com
    Signed-off-by: Jeff Cody <jcody@redhat.com>
    jnsnow committed with codyprime Feb 25, 2016
  4. @famz @codyprime

    mirror: Add mirror_wait_for_io

    The three lines are duplicated a number of times now, refactor a
    function.
    
    Signed-off-by: Fam Zheng <famz@redhat.com>
    Reviewed-by: Max Reitz <mreitz@redhat.com>
    Message-id: 1454637630-10585-3-git-send-email-famz@redhat.com
    Signed-off-by: Jeff Cody <jcody@redhat.com>
    famz committed with codyprime Feb 5, 2016
  5. @famz @codyprime

    mirror: Rewrite mirror_iteration

    The "pnum < nb_sectors" condition in deciding whether to actually copy
    data is unnecessarily strict, and the qiov initialization is
    unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard.
    
    Rewrite mirror_iteration to fix both flaws.
    
    The output of iotests 109 is updated because we now report the offset
    and len slightly differently in mirroring progress.
    
    Signed-off-by: Fam Zheng <famz@redhat.com>
    Reviewed-by: Max Reitz <mreitz@redhat.com>
    Message-id: 1454637630-10585-2-git-send-email-famz@redhat.com
    Signed-off-by: Jeff Cody <jcody@redhat.com>
    famz committed with codyprime Feb 5, 2016
  6. @XanClic @codyprime

    vhdx: Simplify vhdx_set_shift_bits()

    For values which are powers of two (and we do assume all of these to
    be), sizeof(x) * 8 - 1 - clz(x) == ctz(x). Therefore, use ctz().
    
    Signed-off-by: Max Reitz <mreitz@redhat.com>
    Message-id: 1450451066-13335-3-git-send-email-mreitz@redhat.com
    Signed-off-by: Jeff Cody <jcody@redhat.com>
    XanClic committed with codyprime Dec 18, 2015
  7. @XanClic @codyprime

    vhdx: DIV_ROUND_UP() in vhdx_calc_bat_entries()

    We have DIV_ROUND_UP(), so we can use it to produce more easily readable
    code. It may be slower than the bit shifting currently performed
    (because it actually performs a division), but since
    vhdx_calc_bat_entries() is never used in a hot path, this is completely
    fine.
    
    Signed-off-by: Max Reitz <mreitz@redhat.com>
    Message-id: 1450451066-13335-2-git-send-email-mreitz@redhat.com
    Signed-off-by: Jeff Cody <jcody@redhat.com>
    XanClic committed with codyprime Dec 18, 2015
Something went wrong with that request. Please try again.