Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
branch: qom-cpu-vmstate
Commits on Jun 18, 2013
  1. cpu: Guard cpu_{save,load}() definitions

    authored
    A few targets already managed to implement cpu_save() and cpu_load()
    without defining CPU_SAVE_VERSION that causes them to be registered.
    
    Guard the prototypes with CPU_SAVE_VERSION to avoid this happening again
    until all targets are converted to VMState (or QIDL).
    
    Reviewed-by: Juan Quintela <quintela@redhat.com>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
  2. target-openrisc: Register VMStateDescription for OpenRISCCPU

    authored
    Since commit e67db06 (target-or32: Add
    target stubs and QOM cpu) a VMStateDescription existed, but
    CPU_SAVE_VERSION was not set, so it was never registered.
    
    Drop cpu_{save,load}() and register VMStateDescription via DeviceState.
    Use a version_id of 1 and specify minimum versions as well.
    
    Reviewed-by: Juan Quintela <quintela@redhat.com>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
  3. target-alpha: Register VMStateDescription for AlphaCPU

    authored
    Commit b758aca (target-alpha: Enable
    the alpha-softmmu target.) introduced cpu_{save,load}() functions but
    didn't define CPU_SAVE_VERSION, so they were never registered.
    
    Drop cpu_{save,load}() and register the VMStateDescription via DeviceClass.
    This operates on the AlphaCPU object instead of CPUAlphaState.
    
    Reviewed-by: Juan Quintela <quintela@redhat.com>
    Acked-by: Richard Henderson <rth@twiddle.net>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
  4. cpu: Introduce VMSTATE_CPU() macro for CPUState

    authored
    To be used to embed common CPU state into CPU subclasses.
    
    Reviewed-by: Juan Quintela <quintela@redhat.com>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
  5. cpu: Introduce device_class_set_vmsd() helper

    authored
    It's the equivalent to cpu_class_set_vmsd(), to assign
    DeviceClass::vmsd. It wasn't needed before since only static,
    unmigratable VMStateDescriptions were assigned so far.
    
    Reviewed-by: Juan Quintela <quintela@redhat.com>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
  6. cpu: Fix cpu_class_set_vmsd() documentation

    authored
    It's CPUClass::vmsd, not CPUState::vmsd.
    
    Reviewed-by: liguang <lig.fnst@cn.fujitsu.com>
    Reviewed-by: Juan Quintela <quintela@redhat.com>
    Signed-off-by: Andreas Färber <afaerber@suse.de>
  7. @pete128 @edgarigl

    intc/xilinx_intc: Dont lower IRQ when HIE cleared

    pete128 authored edgarigl committed
    This is a little strange. It is lowering the parent IRQ pin on input
    when HIE is cleared. There is no such behaviour in the real hardware.
    
    ISR changes based on interrupt pin state are already guarded on HIE
    being set. So we can just delete this if in its entirety.
    
    Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
    Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
  8. @pete128 @edgarigl

    intc/xilinx_intc: Inhibit write to ISR when HIE

    pete128 authored edgarigl committed
    When the Hardware Interrupt Enable (HIE) bit is set, software cannot
    change ISR. Add write guard accordingly.
    
    Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
    Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
  9. @pete128 @edgarigl

    intc/xilinx_intc: Handle level interrupt retriggering

    pete128 authored edgarigl committed
    Acking a level sensitive interrupt should have no effect if the
    interrupt pin is still asserted. The current implementation requires
    and edge condition to occur for setting a level sensitive IRQ, which
    means an ACK can clear a level sensitive interrupt, until the original
    source strobes the interrupt again.
    
    Fix by keeping track of the interrupt pin state and setting ISR based
    on this every time update_irq() is called.
    
    Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
    Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
  10. @pete128 @edgarigl

    intc/xilinx_intc: Don't clear level sens. IRQs without ACK

    pete128 authored edgarigl committed
    For level sensitive interrupts, ISR bits are cleared when the input pin
    is lowered. This is incorrect. Only software can clear ISR bits (via
    IAR or direct write to ISR with !MER(2)).
    
    Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
    Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
  11. @pete128 @edgarigl

    microblaze/petalogix_s3adsp1800_mmu: Fix UART IRQ

    pete128 authored edgarigl committed
    The UART IRQ is edge sensitive, whereas the machine was registering it
    as level sensitive. Fix.
    
    Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
    Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
Commits on Jun 17, 2013
  1. Merge remote-tracking branch 'luiz/queue/qmp' into staging

    Anthony Liguori authored
    # By Luiz Capitulino
    # Via Luiz Capitulino
    * luiz/queue/qmp:
      qerror: drop QERR_OPEN_FILE_FAILED macro
      block: bdrv_reopen_prepare(): don't use QERR_OPEN_FILE_FAILED
      savevm: qmp_xen_save_devices_state(): use error_setg_file_open()
      dump: qmp_dump_guest_memory(): use error_setg_file_open()
      cpus: use error_setg_file_open()
      blockdev: use error_setg_file_open()
      block: mirror_complete(): use error_setg_file_open()
      rng-random: use error_setg_file_open()
      error: add error_setg_file_open() helper
    
    Message-id: 1371484631-29510-1-git-send-email-lcapitulino@redhat.com
    Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
  2. Merge remote-tracking branch 'kwolf/for-anthony' into staging

    Anthony Liguori authored
    # By Liu Yuan (2) and others
    # Via Kevin Wolf
    * kwolf/for-anthony:
      vmdk: Allow reading variable size descriptor files
      NVMe: Initial commit for new storage interface
      curl: Don't set curl options on the handle just before it's going to be deleted.
      vmdk: byteswap VMDK4Header.desc_offset field
      block/curl.c: Refuse to open the handle for writes.
      sheepdog: support 'qemu-img snapshot -a'
      sheepdog: fix snapshot tag initialization
    
    Message-id: 1371486710-17793-1-git-send-email-kwolf@redhat.com
    Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
  3. Merge remote-tracking branch 'rth/fix-ppc64' into staging

    Anthony Liguori authored
    # By Anton Blanchard
    # Via Richard Henderson
    * rth/fix-ppc64:
      tcg-ppc64: rotr_i32 rotates wrong amount
      tcg-ppc64: Fix add2_i64
      tcg-ppc64: bswap64 rotates output 32 bits
      tcg-ppc64: Fix RLDCL opcode
    
    Message-id: 1371491129-30246-1-git-send-email-rth@twiddle.net
    Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
  4. @antonblanchard @rth7680

    tcg-ppc64: rotr_i32 rotates wrong amount

    antonblanchard authored rth7680 committed
    rotr_i32 calculates the amount to left shift and puts it into a
    temporary, but then doesn't use it when doing the shift.
    
    Cc: qemu-stable@nongnu.org
    Signed-off-by: Anton Blanchard <anton@samba.org>
    Signed-off-by: Richard Henderson <rth@twiddle.net>
  5. @antonblanchard @rth7680

    tcg-ppc64: Fix add2_i64

    antonblanchard authored rth7680 committed
    add2_i64 was adding the lower double word to the upper double word
    of each input. Fix this so we add the lower double words, then the
    upper double words with carry propagation.
    
    Cc: qemu-stable@nongnu.org
    Signed-off-by: Anton Blanchard <anton@samba.org>
    Signed-off-by: Richard Henderson <rth@twiddle.net>
  6. @antonblanchard @rth7680

    tcg-ppc64: bswap64 rotates output 32 bits

    antonblanchard authored rth7680 committed
    If our input and output is in the same register, bswap64 tries to
    undo a rotate of the input. This just ends up rotating the output.
    
    Cc: qemu-stable@nongnu.org
    Signed-off-by: Anton Blanchard <anton@samba.org>
    Signed-off-by: Richard Henderson <rth@twiddle.net>
  7. @antonblanchard @rth7680

    tcg-ppc64: Fix RLDCL opcode

    antonblanchard authored rth7680 committed
    The rldcl instruction doesn't have an sh field, so the minor opcode
    is shifted 1 bit. We were using the XO30 macro which shifted the
    minor opcode 2 bits.
    
    Remove XO30 and add MD30 and MDS30 macros which match the
    Power ISA categories.
    
    Cc: qemu-stable@nongnu.org
    Signed-off-by: Anton Blanchard <anton@samba.org>
    Signed-off-by: Richard Henderson <rth@twiddle.net>
  8. vmdk: Allow reading variable size descriptor files

    Evgeny Budilovsky authored Kevin Wolf committed
    the hard-coded 2k buffer on the stack won't allow reading big descriptor
    files which can be generated when storing big images. For example 500G
    vmdk splitted to 2G chunks.
    
    Signed-off-by: Evgeny Budilovsky <evgeny.budilovsky@ravellosystems.com>
    Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
    Signed-off-by: Kevin Wolf <kwolf@redhat.com>
  9. @keithbusch

    NVMe: Initial commit for new storage interface

    keithbusch authored Kevin Wolf committed
    Initial commit for emulated Non-Volatile-Memory Express (NVMe) pci
    storage device.
    
    NVMe is an open, industry driven storage specification defining
    an optimized register and command set designed to deliver the full
    capabilities of non-volatile memory on PCIe SSDs. Further information
    may be found on the organizations website at:
    
    http://www.nvmexpress.org/
    
    This commit implements the minimum from the specification to work with
    existing drivers.
    
    Cc: Keith Busch <keith.busch@gmail.com>
    Signed-off-by: Keith Busch <keith.busch@intel.com>
    Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
    Signed-off-by: Kevin Wolf <kwolf@redhat.com>
  10. @rwmjones

    curl: Don't set curl options on the handle just before it's going to …

    rwmjones authored Kevin Wolf committed
    …be deleted.
    
    (Found by Kamil Dudka)
    
    Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
    Cc: Michael Tokarev <mjt@tls.msk.ru>
    Signed-off-by: Kevin Wolf <kwolf@redhat.com>
  11. vmdk: byteswap VMDK4Header.desc_offset field

    Stefan Hajnoczi authored Kevin Wolf committed
    Remember to byteswap VMDK4Header.desc_offset on big-endian machines.
    
    Cc: qemu-stable@nongnu.org
    Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
    Signed-off-by: Kevin Wolf <kwolf@redhat.com>
  12. @rwmjones

    block/curl.c: Refuse to open the handle for writes.

    rwmjones authored Kevin Wolf committed
    Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
    Signed-off-by: Fam Zheng <famz@redhat.com>
    Signed-off-by: Kevin Wolf <kwolf@redhat.com>
  13. @liuy

    sheepdog: support 'qemu-img snapshot -a'

    liuy authored Kevin Wolf committed
    Just call sd_create_branch() in the snapshot_goto to rollback the image is good
    enough. With this patch, 'loadvm' process for sheepdog is modified:
    
    Suppose we have a snapshot chain A --> B --> C, we do 'loadvm A' so as to get
    a new chain,
    
    A --> B
    |
    V
    C1
    
    in the old code:
    
    1 reload inode of A (in snapshot_goto)
    2 read vmstate via A's vdi_id (loadvm_state)
    3 delete C and create C1, reload inode of C1 (sd_create_branch on write)
    
    with this patch applied:
    
    1 reload inode of A, delete C and create C1  (in snapshot_goto)
    2 read vmstate via C1's parent, that is A's vdi_id (loadvm_state)
    
    This will fix the possible bug that QEMU exit between 2 and 3 in the old code
    
    Cc: qemu-devel@nongnu.org
    Cc: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
    Cc: Kevin Wolf <kwolf@redhat.com>
    Cc: Stefan Hajnoczi <stefanha@redhat.com>
    Signed-off-by: Liu Yuan <namei.unix@gmail.com>
    Signed-off-by: Kevin Wolf <kwolf@redhat.com>
  14. @liuy

    sheepdog: fix snapshot tag initialization

    liuy authored Kevin Wolf committed
    This is an old and obvious bug. We should pass snapshot_id to the
    tag. Or simple command like 'qemu-img snapshot -a tag sheepdog:image' will fail
    
    Cc: qemu-devel@nongnu.org
    Cc: MORITA Kazutaka <morita.kazutaka@lab.ntt.co.jp>
    Cc: Kevin Wolf <kwolf@redhat.com>
    Cc: Stefan Hajnoczi <stefanha@redhat.com>
    Reviewed-by: Kevin Wolf <kwolf@redhat.com>
    Signed-off-by: Liu Yuan <namei.unix@gmail.com>
    Signed-off-by: Kevin Wolf <kwolf@redhat.com>
  15. qerror: drop QERR_OPEN_FILE_FAILED macro

    Luiz Capitulino authored
    Not used since the last commit.
    
    Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
    Acked-by: Kevin Wolf <kwolf@redhat.com>
  16. block: bdrv_reopen_prepare(): don't use QERR_OPEN_FILE_FAILED

    Luiz Capitulino authored
    The call to drv->bdrv_reopen_prepare() can fail due to reasons
    other than an open failure. Unfortunately, we can't use errno
    nor -ret, cause they are not always set.
    
    Stick to a generic error message then.
    
    Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
    Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
    Acked-by: Kevin Wolf <kwolf@redhat.com>
  17. savevm: qmp_xen_save_devices_state(): use error_setg_file_open()

    Luiz Capitulino authored
    Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
    Acked-by: Kevin Wolf <kwolf@redhat.com>
  18. dump: qmp_dump_guest_memory(): use error_setg_file_open()

    Luiz Capitulino authored
    Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
    Acked-by: Kevin Wolf <kwolf@redhat.com>
  19. cpus: use error_setg_file_open()

    Luiz Capitulino authored
    Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
    Acked-by: Kevin Wolf <kwolf@redhat.com>
  20. blockdev: use error_setg_file_open()

    Luiz Capitulino authored
    Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
    Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
    Acked-by: Kevin Wolf <kwolf@redhat.com>
  21. block: mirror_complete(): use error_setg_file_open()

    Luiz Capitulino authored
    Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
    Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
    Acked-by: Kevin Wolf <kwolf@redhat.com>
  22. rng-random: use error_setg_file_open()

    Luiz Capitulino authored
    Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
    Acked-by: Kevin Wolf <kwolf@redhat.com>
  23. error: add error_setg_file_open() helper

    Luiz Capitulino authored
    Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
    Acked-by: Kevin Wolf <kwolf@redhat.com>
  24. Merge remote-tracking branch 'pmaydell/configury.next' into staging

    Anthony Liguori authored
    # By Paolo Bonzini (4) and others
    # Via Peter Maydell
    * pmaydell/configury.next:
      ppc: Remove CONFIG_FDT conditionals
      microblaze: Remove CONFIG_FDT conditionals
      arm: Remove CONFIG_FDT conditionals
      configure: Require libfdt for arm, ppc, microblaze softmmu targets
      configure: dtc: Probe for libfdt_env.h
      build: drop TARGET_TYPE
      main: use TARGET_ARCH only for the target-specific #define
      build: do not use TARGET_ARCH
      build: rename TARGET_ARCH2 to TARGET_NAME
      Add a stp file for usage from build directory
    
    Message-id: 1371221594-11556-1-git-send-email-peter.maydell@linaro.org
    Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Something went wrong with that request. Please try again.