Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete removeAttribute('value') on input change #123

Closed
wants to merge 1 commit into from
Closed

Delete removeAttribute('value') on input change #123

wants to merge 1 commit into from

Conversation

seb-jean
Copy link
Contributor

@seb-jean seb-jean commented Nov 4, 2022

It is not useful to remove the value attribute

@netlify
Copy link

netlify bot commented Nov 4, 2022 •
edited
Loading

✅ Deploy Preview for stimulus-autocomplete canceled.

Name Link
🔨 Latest commit 2e4d4a7
🔍 Latest deploy log https://app.netlify.com/sites/stimulus-autocomplete/deploys/6364f24cb26182000869ab2a

@afcapel
Copy link
Owner

afcapel commented Mar 1, 2023

Thanks @seb-jean, good point 👍

I've merged the change in bdb1753 with a more explanatory commit message.

@afcapel afcapel closed this Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seb-jean @afcapel