Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve ActiveSupport version w/ old rubies #31

Closed
afeld opened this issue Feb 18, 2014 · 5 comments
Closed

Resolve ActiveSupport version w/ old rubies #31

afeld opened this issue Feb 18, 2014 · 5 comments
Labels

Comments

@afeld
Copy link
Owner

afeld commented Feb 18, 2014

The gemspec does't set a max version for ActiveSupport, so the build is trying to install 4.x, which requires Ruby >= 1.9.3. Two possible solutions:

@jcn
Copy link
Collaborator

jcn commented Feb 19, 2014

It probably makes sense to pin it to ActiveSupport < 4 at this point, unless there's anything explicitly in ActiveSupport 4 that would be helpful. As long as it's supported, we might as well maintain compatibility with older rubies.

@tolsen
Copy link
Collaborator

tolsen commented Feb 19, 2014

Does this mean that magickly would not be compatible with Rails 4 ?

Is there any way to require different versions based on the version of Ruby installed?

@afeld
Copy link
Owner Author

afeld commented Feb 19, 2014

I was thinking of just starting a new major version w/ Rails 4+ support, but sounds like there is a way to do conditional gem support:

http://www.programmersparadox.com/2012/05/21/gemspec-loading-dependent-gems-based-on-the-users-system/

Will take a crack at it.

@afeld
Copy link
Owner Author

afeld commented Feb 19, 2014

If that doesn't work, I'll just cut a new major version, and tell people they can use Magickly ~> 1.4 for Rails < 4 and Ruby < 1.9.3. Leaning this direction, actually, so that no extra effort needs to be put into supporting legacy platforms.

@afeld
Copy link
Owner Author

afeld commented Feb 19, 2014

K, was just easier to drop support with a new major version than to try and support the old Rails/Ruby. We can make a 1-x-stable branch if we feel the need.

@afeld afeld closed this as completed Feb 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants