-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve ActiveSupport version w/ old rubies #31
Comments
It probably makes sense to pin it to ActiveSupport < 4 at this point, unless there's anything explicitly in ActiveSupport 4 that would be helpful. As long as it's supported, we might as well maintain compatibility with older rubies. |
Does this mean that magickly would not be compatible with Rails 4 ? Is there any way to require different versions based on the version of Ruby installed? |
I was thinking of just starting a new major version w/ Rails 4+ support, but sounds like there is a way to do conditional gem support: Will take a crack at it. |
If that doesn't work, I'll just cut a new major version, and tell people they can use Magickly |
K, was just easier to drop support with a new major version than to try and support the old Rails/Ruby. We can make a |
The gemspec does't set a max version for ActiveSupport, so the build is trying to install
4.x
, which requires Ruby >= 1.9.3. Two possible solutions:s.add_dependency('activesupport', '>= 2.0.0', '< 4')
The text was updated successfully, but these errors were encountered: