From 2e0f874f6491a5a27819d904c2f44640ab8e11cd Mon Sep 17 00:00:00 2001 From: Aidan Feldman Date: Wed, 19 Mar 2025 00:15:30 -0400 Subject: [PATCH 1/2] check for double-escaping --- .github/workflows/publish.yml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 30176592..f99831a2 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -46,6 +46,17 @@ jobs: # path: ./ - name: Render for school run: ./extras/scripts/school_ci.sh ${{ matrix.school }} + + # have had issues with nbgitpuller URLs being double-escaped, which causes an error when trying to open it + - name: Confirm there isn't double-escaping + run: | + if grep -r "&" _build/html; then + echo "Double-escaped URL" + exit 1 + else + echo "No double-escaping" + fi + - name: Update commit run: | git add -A From d986dc8f164410d1f1fdf7cf91f6090caa52ac8b Mon Sep 17 00:00:00 2001 From: Aidan Feldman Date: Wed, 19 Mar 2025 01:04:35 -0400 Subject: [PATCH 2/2] fix double-escaping --- .github/workflows/publish.yml | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index f99831a2..8a00b657 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -47,15 +47,10 @@ jobs: - name: Render for school run: ./extras/scripts/school_ci.sh ${{ matrix.school }} - # have had issues with nbgitpuller URLs being double-escaped, which causes an error when trying to open it - - name: Confirm there isn't double-escaping - run: | - if grep -r "&" _build/html; then - echo "Double-escaped URL" - exit 1 - else - echo "No double-escaping" - fi + # https://github.com/jupyter-book/jupyter-book/issues/2271 + # https://stackoverflow.com/a/1583282/358804 + - name: Fix double-escaping + run: find _build/html -name '*.html' -print0 | xargs -0 sed -i 's/&/\&/g' - name: Update commit run: |