Skip to content
This repository has been archived by the owner on Oct 13, 2022. It is now read-only.

#25-構造化タグをちゃんとした #27

Merged
merged 6 commits into from Feb 13, 2020
Merged

#25-構造化タグをちゃんとした #27

merged 6 commits into from Feb 13, 2020

Conversation

su8ru
Copy link
Member

@su8ru su8ru commented Feb 12, 2020

fix #25

@su8ru su8ru added the enhancement New feature or request label Feb 12, 2020
@su8ru su8ru requested a review from ibuki2003 February 12, 2020 15:00
@su8ru su8ru self-assigned this Feb 12, 2020
@su8ru su8ru added this to In progress in develop via automation Feb 12, 2020
ibuki2003
ibuki2003 suggested changes Feb 12, 2020
View reviewed changes
Copy link
Member

@ibuki2003 ibuki2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ここでついでにclassからidに変える変更やって(もらって)もいいですか

src/App.vue Outdated Show resolved Hide resolved
develop automation moved this from In progress to Review in progress Feb 12, 2020
@su8ru su8ru requested a review from ibuki2003 February 13, 2020 09:40
develop automation moved this from Review in progress to Reviewer approved Feb 13, 2020
@su8ru su8ru merged commit 358396c into develop Feb 13, 2020
develop automation moved this from Reviewer approved to Done Feb 13, 2020
@su8ru su8ru deleted the feature/#25_improve_structure_tags branch February 13, 2020 09:58
@su8ru su8ru added this to Done in ProjectManager Feb 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ibuki2003 ibuki2003 ibuki2003 approved these changes

Assignees

@su8ru su8ru

Labels
enhancement New feature or request
Projects
ProjectManager
  
Done
develop
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

index.html や App.vue のタグをちゃんとする
2 participants
@su8ru @ibuki2003