Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FolderNameFilter handles messages in multiple folders. #74

Closed
wants to merge 1 commit into from

Conversation

daewok
Copy link
Contributor

@daewok daewok commented Mar 1, 2014

The FolderNameFilter used to look only at a message's primary folder (message.get_filename()) when deciding which tags to apply. This change allows the filter to look at all folders that a message exists in when applying the tags.

This was done by retrieving all filenames using message.get_filenames() and adding the appropriate processing to handle the list of file names.

This change would be especially useful for those using GMail to add tags to their messages.

Switched from message.get_filename() to message.get_filenames() and added appropriate processing to handle the list of file names.
@ryneeverett
Copy link

Needs rebasing, but otherwise works great!

@GuillaumeSeren
Copy link
Collaborator

hey @daewok @ryneeverett 🍻 🍻
I use Gmail and so this would be neat to have, can you rebase the patch please ?

@varac
Copy link

varac commented May 29, 2017

hey @daewok @ryneeverett  
I use Gmail and so this would be neat to have, can you rebase the patch please ?

Yes please! I'd like to have this included into afew as well.

@GuillaumeSeren If @daewok is not responding, could you pls rebase and merge yourself ?
I just rebased the foldername_filter on top of current master locally without any problem.

@GuillaumeSeren
Copy link
Collaborator

@varac Hey, I have rebased the commit so I close this PR in favor of the new one -> #145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants