core fixes

afinch7 · Aug 28, 2019 · 9512b2f · 9512b2f
1 parent f4f0b6f
commit 9512b2f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/core/core.d.ts b/core/core.d.ts
@@ -5,7 +5,7 @@
 // Deno and therefore do not flow through to the runtime type library.
 
 declare interface MessageCallback {
-  (opId: number, msg: Uint8Array): void;
+  (msg: Uint8Array): void;
 }
 
 declare type DenoOpListener = (id: number | undefined) => void;

diff --git a/core/core_lib.js b/core/core_lib.js
@@ -165,7 +165,9 @@ SharedQueue Binary Layout
 
     function setAsyncHandler(opId, cb) {
       maybeInit();
-      asyncHandlerMap[opId] = cb;
+      if (typeof opId === "number") {
+        asyncHandlerMap[opId] = cb;
+      }
     }
 
     function handleAsyncMsgFromRust(opId, buf) {

diff --git a/core/libdeno/libdeno.d.ts b/core/libdeno/libdeno.d.ts
@@ -13,7 +13,7 @@ interface EvalErrorInfo {
 }
 
 declare interface MessageCallback {
-  (opId: number, msg: Uint8Array): void;
+  (msg: Uint8Array): void;
 }
 
 declare interface OpRegisterCallback {