Join GitHub today
Request for comments on the two tests added #16
I have been a bit swamped of late. So Judging by the commits I am assuming that these are a couple of unit tests. Would you mind going into some detail on the reason there are two files that are very nearly exactly the same? I am not a big fan of code duplication and I suspect once we know your purpose we can optimize this a bit.
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
Yes well this seems to be a bug present in both API's when checking siblings in relatives. Maybe somethings missing?
The tests are designed to pass unless you uncomment the BREAK definition.
I am not surprised the tests are not functional. Its an unreleased work in progress (WIP) and should be taken as such until it is released (even as an alpha). @yrashk has been promoting it on irc, which is all good, but he has not been letting people know that it is not complete, not even as an alpha. All that said I do still appreciate contributions.
Ok, with all of that out of the way you have cleared up a misconception on my part. I didn't realize this was pull request was mostly to illustrate brokenness in the code base not necessarily as an actual request to add code to the codebase. In light of that, I will probably take these, work up some illustrative tests and and commit those tests along with the fixes for them.
Again, I hope the tone of this did not come off poorly. I do very much appreciate finding and especially taking the time to illustrate bugs.
Rereading this comment to myself it comes off as pretty defensive. Which shouldn't be. Its code after all. The tests in the canonical repo should pass or the code shouldn't be in canonical regardless of the state of the project. Another area where working solo has made me a bit lazy. As an aside to the commits I will get that problem resolved as well.