New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove web.xml #10

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@patcon
Contributor

patcon commented Oct 10, 2015

Seems it's not actually a template, but just a file. And since both the installer and standalone packages already come with a copy most-suited to the needs of that version, it's probably best to let them handle it.

This likely hinges on #9

@patcon

This comment has been minimized.

Show comment
Hide comment
@patcon

patcon Oct 10, 2015

Contributor

Just realized this doesn't rely on the #9

Contributor

patcon commented Oct 10, 2015

Just realized this doesn't rely on the #9

@patcon

This comment has been minimized.

Show comment
Hide comment
@patcon

patcon Oct 10, 2015

Contributor

ready for review

Contributor

patcon commented Oct 10, 2015

ready for review

@patcon patcon referenced this pull request Oct 10, 2015

Closed

Remove war support #9

@mvdkleijn

This comment has been minimized.

Show comment
Hide comment
@mvdkleijn

mvdkleijn Oct 12, 2015

Member

This makes sense, but I'll have to check what the difference is between a standard 6.4.11 web.xml and the one we include. I suspect the HTTPS security constraint was added. I'll get back to this.

Member

mvdkleijn commented Oct 12, 2015

This makes sense, but I'll have to check what the difference is between a standard 6.4.11 web.xml and the one we include. I suspect the HTTPS security constraint was added. I'll get back to this.

@mvdkleijn

This comment has been minimized.

Show comment
Hide comment
@mvdkleijn

mvdkleijn Oct 12, 2015

Member

merged locally

Member

mvdkleijn commented Oct 12, 2015

merged locally

@mvdkleijn mvdkleijn closed this Oct 12, 2015

@patcon patcon deleted the patcon:feature/10-remove-web-xml-template branch Oct 12, 2015

@legal90 legal90 referenced this pull request Jul 13, 2016

Merged

Remove "web.xml" template #116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment