New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use proxy server.xml settings even without ssl enabled #11

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@patcon
Contributor

patcon commented Oct 9, 2015

The setup wizard seems to take the base url from the proxy settings, and defaults to localhost without. This seems to solve that. (PR forthcoming)

@patcon

This comment has been minimized.

Show comment
Hide comment
@patcon

patcon Oct 9, 2015

Contributor

How it works with the change

screen cap

Contributor

patcon commented Oct 9, 2015

How it works with the change

screen cap

@patcon

This comment has been minimized.

Show comment
Hide comment
@patcon

patcon Oct 9, 2015

Contributor

Could also take this opportunity to "fix" the virtual_host_name and virtual_host_alias, as was done in the confluence cookbook:

Contributor

patcon commented Oct 9, 2015

Could also take this opportunity to "fix" the virtual_host_name and virtual_host_alias, as was done in the confluence cookbook:

@patcon

This comment has been minimized.

Show comment
Hide comment
@patcon

patcon Oct 9, 2015

Contributor

ready for review

Contributor

patcon commented Oct 9, 2015

ready for review

@patcon patcon referenced this pull request Oct 10, 2015

Closed

Remove war support #9

@mvdkleijn

This comment has been minimized.

Show comment
Hide comment
@mvdkleijn

mvdkleijn Oct 12, 2015

Member

Merged manually locally. Will push to GH later.

Member

mvdkleijn commented Oct 12, 2015

Merged manually locally. Will push to GH later.

@mvdkleijn mvdkleijn closed this Oct 12, 2015

@patcon patcon deleted the patcon:feature/11-improve-proxy-settings branch Oct 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment