New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update old database-type string for postgres 9.2 & 9.3 #14

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@patcon
Contributor

patcon commented Oct 9, 2015

https://github.com/afklm/chef_jira/blob/f40871326283f1dde233b1e3f1a009c8173ba022/templates/default/dbconfig.xml.erb#L10

In the line above, the database-type is set to postgres. It seems that since at least postgres 9.2, postgres72 should be used. I've confirmed this bug and fix for Jira v6.4.11 with postgresql v9.3.9, and the docs say it should be the same for psql 9.2

We could make it dynamic based on postgres version, but I think we should fix it now, and fix it for older versions if we add convergence tests for them :)

Reference: https://github.com/afklm/chef_jira/blob/master/templates/default/dbconfig.xml.erb#L10

@patcon

This comment has been minimized.

Show comment
Hide comment
@patcon

patcon Oct 10, 2015

Contributor

fwiw I think it's postgres 8.x that used the old type postgres, but not 100%

Contributor

patcon commented Oct 10, 2015

fwiw I think it's postgres 8.x that used the old type postgres, but not 100%

@patcon

This comment has been minimized.

Show comment
Hide comment
@patcon

patcon Oct 10, 2015

Contributor

ready for review

Contributor

patcon commented Oct 10, 2015

ready for review

@patcon patcon referenced this pull request Oct 10, 2015

Closed

Remove war support #9

@mvdkleijn

This comment has been minimized.

Show comment
Hide comment
@mvdkleijn

mvdkleijn Oct 12, 2015

Member

Merge locally, will push to GH later.

Member

mvdkleijn commented Oct 12, 2015

Merge locally, will push to GH later.

@mvdkleijn mvdkleijn closed this Oct 12, 2015

@patcon patcon deleted the patcon:feature/14-update-dbconfig-type branch Oct 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment