Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support per activity InflationDelegates #120

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@iota9star
Copy link
Contributor

commented Nov 4, 2018

Each activity may have different InflationDelegate.

/** Should be called before super.onCreate() in each Activity. */
@JvmStatic
fun attach(whereAmI: Context): Aesthetic {
fun attach(whereAmI: Context, inflationDelegate: InflationDelegate?): Aesthetic {

This comment has been minimized.

Copy link
@afollestad

afollestad Nov 4, 2018

Owner

The second parameter should have a default value, two methods aren't needed since we're using Kotlin

This comment has been minimized.

Copy link
@afollestad

afollestad Nov 4, 2018

Owner

You can use the @JvmOverloads annotation for Java support, as well

@afollestad afollestad changed the title support per activity have different InflationDelegate. Support per activity InflationDelegates Nov 4, 2018

@afollestad afollestad self-assigned this Nov 4, 2018

@@ -653,7 +656,7 @@ class Aesthetic private constructor(private var context: Context?) {
* tint, since that is handled by Aesthetic without view swapping.
*/
@JvmStatic
fun setInflationDelegate(inflationDelegate: InflationDelegate) {
fun setDefaultInflationDelegate(inflationDelegate: InflationDelegate?) {

This comment has been minimized.

Copy link
@afollestad

afollestad Nov 4, 2018

Owner

This is a breaking change

@afollestad afollestad closed this in cf27891 Nov 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.