New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird behavior of action buttons in small screens #1697

Open
jahirfiquitiva opened this Issue Jan 9, 2019 · 5 comments

Comments

Projects
2 participants
@jahirfiquitiva
Copy link

jahirfiquitiva commented Jan 9, 2019

Library Version:

2.0.0-rc7

Affected Device(s):

All devices with small screens

Describe the Bug:

Hi Aidan

I am showing a dialog with a custom view and the buttons are behaving really weird.

Pictures descriptions because the pictures are big 😓

  1. This is the dialog in a normal screen, without the keyboard shown (aka expected behavior).
  2. This is the dialog in a small screen before showing the keyboard.
  3. This is the dialog in a small screen while showing the keyboard.
  4. This is the dialog in a small screen after hiding the keyboard.

This is the dialog in a normal screen, without the keyboard shown (aka expected behavior).


This is the dialog in a small screen before showing the keyboard.


This is the dialog in a small screen while showing the keyboard.


This is the dialog in a small screen after hiding the keyboard.

@afollestad

This comment has been minimized.

Copy link
Owner

afollestad commented Jan 9, 2019

A trick I use with pictures on GitHub is straight up HTML 😄

<img src="url" width="250" />

After the picture uploads I just take out the URL and put it in an img tag

@afollestad afollestad added the bug label Jan 9, 2019

@afollestad afollestad self-assigned this Jan 9, 2019

@afollestad afollestad added this to To do in Roadmap via automation Jan 9, 2019

@afollestad afollestad added this to the version 2.0 stable milestone Jan 9, 2019

@afollestad

This comment has been minimized.

Copy link
Owner

afollestad commented Jan 9, 2019

Oh interesting - the keyboard must be causing a remeasure, making the dialog change it's decision on being "stacked".

@afollestad

This comment has been minimized.

Copy link
Owner

afollestad commented Jan 9, 2019

@jahirfiquitiva oddly, I'm unable to reproduce.

Are you changing the soft input mode of your dialogs?

Edit: Oh wait, your custom view isn't in a ScrollView. That's probably effecting it. Will try that way.

@afollestad

This comment has been minimized.

Copy link
Owner

afollestad commented Jan 9, 2019

Huh, even when not scrollable, I don't see that problem on a Nexus 5.

@jahirfiquitiva

This comment has been minimized.

Copy link

jahirfiquitiva commented Jan 9, 2019

Thanks for letting me know about the images trick.

My custom view is a full width card, and a recyclerview below

Also, I set these flags in the AndroidManifest.xml:
android:windowSoftInputMode="stateAlwaysHidden|adjustResize"

afollestad added a commit that referenced this issue Jan 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment