New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too much button padding when using a custom view #1698

Closed
jahirfiquitiva opened this Issue Jan 9, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@jahirfiquitiva
Copy link

jahirfiquitiva commented Jan 9, 2019

Library Version:

2.0.0-rc7

Affected Device(s):

Any

Describe the Bug:

After a recent update (I'm guessing this change) the buttons in a dialog with a custom view have too much padding and they don't look that good :/

Dialog covered with an 8dp grid

photo5021569621412653038

@afollestad

This comment has been minimized.

Copy link
Owner

afollestad commented Jan 9, 2019

Don't think it's the padding. Looks like it's more the margin in between:

screen shot 2019-01-09 at 12 35 33 pm

@afollestad

This comment has been minimized.

Copy link
Owner

afollestad commented Jan 9, 2019

screen shot 2019-01-09 at 12 45 31 pmscreen shot 2019-01-09 at 12 35 33 pm
(https://material.io/design/components/dialogs.html#specs)

^ if I remove the layout margin and only rely on the button inset drawable

afollestad added a commit that referenced this issue Jan 9, 2019

@afollestad afollestad closed this Jan 9, 2019

@jahirfiquitiva

This comment has been minimized.

Copy link

jahirfiquitiva commented Jan 9, 2019

The thing is the spacing between the button text and the dialog border looks bigger than when not using a custom view in the dialog 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment