Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add visible borders to number/string inputs (related to issue #29) #119

Closed
wants to merge 1 commit into from
Closed

add visible borders to number/string inputs (related to issue #29) #119

wants to merge 1 commit into from

Conversation

cvan
Copy link
Contributor

@cvan cvan commented Jul 7, 2016

before

before

## after

after

@cvan
Copy link
Contributor Author

cvan commented Jul 7, 2016

this is just a tweak. to completely close #29, all numeric fields should be properly changed from input.number to <input type="number">/<input type="range">

@fernandojsg
Copy link
Member

Do you think we should center or align right the numbers with the new style?

@caseyyee
Copy link
Contributor

caseyyee commented Jul 7, 2016

I think having a box around the numbers helps make it easy to see that it's a editable field. Also helps with the readability of the numbers as well. In this case, it's aligned-left:

image

(Sketch)

We can use underlines in place of boxes. As long as we are consistent.

Also like that they have X, Y clearly labeled for the fields.

@cvan
Copy link
Contributor Author

cvan commented Jul 8, 2016

👍 to Sketch's treatment

@ngokevin
Copy link
Member

ngokevin commented Dec 9, 2018

ecb2045

@ngokevin ngokevin closed this Dec 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants