From 0da20446b3816bec9acb1ffde29c281adb5bda49 Mon Sep 17 00:00:00 2001
From: M C <machenmusik@gmail.com>
Date: Thu, 22 Mar 2018 19:11:07 -0400
Subject: [PATCH] memoize split strings to reduce garbage; fix matching bugs

---
 src/utils/tracked-controls.js | 24 ++++++++++++++++++++----
 1 file changed, 20 insertions(+), 4 deletions(-)

diff --git a/src/utils/tracked-controls.js b/src/utils/tracked-controls.js
index 7c490044878..d3c44de7d5d 100644
--- a/src/utils/tracked-controls.js
+++ b/src/utils/tracked-controls.js
@@ -2,6 +2,17 @@ var DEFAULT_HANDEDNESS = require('../constants').DEFAULT_HANDEDNESS;
 var AXIS_LABELS = ['x', 'y', 'z', 'w'];
 var NUM_HANDS = 2; // Number of hands in a pair. Should always be 2.
 
+var splitOnPipeMap = {};
+
+function splitOnPipeOnce (stringToSplit) {
+  var rtn = splitOnPipeMap[stringToSplit];
+  if (!rtn) {
+    rtn = stringToSplit.split('|');
+    splitOnPipeMap[stringToSplit] = rtn;
+  }
+  return rtn;
+}
+
 /**
  * Called on controller component `.play` handlers.
  * Check if controller matches parameters and inject tracked-controls component.
@@ -90,19 +101,24 @@ function findMatchingController (controllers, filterIdExact, filterIdPrefix, fil
   var targetControllerMatch = filterControllerIndex || 0;
   var filterIdPrefixes;
   if (filterIdPrefix && filterIdPrefix.indexOf('|') >= 0) {
-    filterIdPrefixes = filterIdPrefix.split('|');
+    filterIdPrefixes = splitOnPipeOnce(filterIdPrefix);
   }
   for (i = 0; i < controllers.length; i++) {
     controller = controllers[i];
     // Determine if the controller ID matches our criteria
     if (filterIdPrefixes) {
       var matches = false;
-      for (var prefix in filterIdPrefixes) {
-        if (prefix && controller.id.indexOf(prefix) === -1) { matches = true; }
+      for (var j = 0; j < filterIdPrefixes.length; j++) {
+        var prefix = filterIdPrefixes[j];
+        console.log(prefix, ' ?= ', controller.id);
+        if (prefix && controller.id.indexOf(prefix) === 0) {
+          matches = true;
+          break;
+        }
       }
       if (!matches) { continue; }
     } else
-    if (filterIdPrefix && controller.id.indexOf(filterIdPrefix) === -1) { continue; }
+    if (filterIdPrefix && controller.id.indexOf(filterIdPrefix) !== 0) { continue; }
     if (!filterIdPrefix && controller.id !== filterIdExact) { continue; }
 
     // If the hand filter and controller handedness are defined we compare them.