New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak default lighting to make less flat #1478

Merged
merged 1 commit into from May 19, 2016

Conversation

Projects
None yet
3 participants
@ngokevin
Member

ngokevin commented May 19, 2016

Description:

Everything was looking flat.

Changes proposed:

  • lower default ambient light
  • strengthen default directional light and reposition

@ngokevin ngokevin force-pushed the ngokevin:fixdefaultambient branch from a39dcb8 to 9449916 May 19, 2016

@dmarcos

This comment has been minimized.

Collaborator

dmarcos commented May 19, 2016

Can you post a couple of screen shots with the before and after?

@ngokevin ngokevin force-pushed the ngokevin:fixdefaultambient branch from 9449916 to 2bde83d May 19, 2016

@ngokevin

This comment has been minimized.

Member

ngokevin commented May 19, 2016

screen shot 2016-05-19 at 11 02 04 am

screen shot 2016-05-19 at 11 04 16 am

@ngokevin ngokevin changed the title from lower default ambient light that makes everything flat to tweak default lighting to make less flat May 19, 2016

@dmarcos

This comment has been minimized.

Collaborator

dmarcos commented May 19, 2016

@fernandojsg what do you think?

@fernandojsg

This comment has been minimized.

Member

fernandojsg commented May 19, 2016

I'll probably go for a lower value for the directional light intensity, something like ~0.6 instead of 0.8 and ambient light for #BBB instead of #AAA.
Having very dark ambient light could produce results that looks more like and old engine with a phong model, and using a high direct light intensity will burn some scenes:
With 0.8 and #AAA:

screenshot 2016-05-19 20 50 49

screenshot 2016-05-19 20 50 44

With 0.6 and #BBB:
screenshot 2016-05-19 20 50 18
screenshot 2016-05-19 20 50 14
screenshot 2016-05-19 20 50 09

@ngokevin ngokevin force-pushed the ngokevin:fixdefaultambient branch from 2bde83d to 1e71070 May 19, 2016

@ngokevin

This comment has been minimized.

Member

ngokevin commented May 19, 2016

updated to .6/bbb

@dmarcos dmarcos merged commit be6446a into aframevr:master May 19, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment