New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an `end` attribute to the animation element. #1491

Merged
merged 7 commits into from May 23, 2016

Conversation

Projects
None yet
2 participants
@msimpson
Contributor

msimpson commented May 20, 2016

Should fix #1036.

@ngokevin

This comment has been minimized.

Member

ngokevin commented May 23, 2016

Do you think you could add a unit test for this?

@msimpson

This comment has been minimized.

Contributor

msimpson commented May 23, 2016

@ngokevin
Okay. I'll try to expand what exists for a-animation to cover it.

@msimpson

This comment has been minimized.

Contributor

msimpson commented May 23, 2016

@ngokevin
Tucked it in at the bottom of the file and based it off the click event begin test.

@ngokevin

This comment has been minimized.

Member

ngokevin commented May 23, 2016

Thanks!

@ngokevin ngokevin merged commit 58bbdaf into aframevr:master May 23, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment