Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upCorrect geometries schemas and add segments parameters for box and plane #1506
Conversation
dmarcos
merged commit 3fcc437
into
aframevr:master
May 27, 2016
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
ngokevin
reviewed
May 27, 2016
| radius: {default: 1, min: 0}, | ||
| radiusTubular: {default: 0.2, min: 0}, | ||
| segmentsRadial: {efault: 36, min: 0, type: 'int'}, | ||
| segmentsTubular: {default: 32, min: 0, type: 'int'} | ||
| segmentsRadial: {efault: 36, min: 3, type: 'int'}, |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
fernandojsg commentedMay 27, 2016
Description:
I've been fixing the
typeand some values likeminormaxfor most of the geometries based on the valid values for the three.js geometry implementation.I've also exposed
segments(Width/Height/Depht)for bothplaneandbox.