Correct geometries schemas and add segments parameters for box and plane #1506
Conversation
| radius: {default: 1, min: 0}, | ||
| radiusTubular: {default: 0.2, min: 0}, | ||
| segmentsRadial: {efault: 36, min: 0, type: 'int'}, | ||
| segmentsTubular: {default: 32, min: 0, type: 'int'} | ||
| segmentsRadial: {efault: 36, min: 3, type: 'int'}, |
ngokevin
May 27, 2016
Member
typo
typo
fernandojsg
May 27, 2016
Author
Member
yep, fixed. thank you
yep, fixed. thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Description:
I've been fixing the
typeand some values likeminormaxfor most of the geometries based on the valid values for the three.js geometry implementation.I've also exposed
segments(Width/Height/Depht)for bothplaneandbox.