New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct geometries schemas and add segments parameters for box and plane #1506

Merged
merged 1 commit into from May 27, 2016

Conversation

Projects
None yet
3 participants
@fernandojsg
Member

fernandojsg commented May 27, 2016

Description:
I've been fixing the type and some values like min or max for most of the geometries based on the valid values for the three.js geometry implementation.
I've also exposed segments(Width/Height/Depht) for both plane and box.

@dmarcos dmarcos merged commit 3fcc437 into aframevr:master May 27, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
radius: {default: 1, min: 0},
radiusTubular: {default: 0.2, min: 0},
segmentsRadial: {efault: 36, min: 0, type: 'int'},
segmentsTubular: {default: 32, min: 0, type: 'int'}
segmentsRadial: {efault: 36, min: 3, type: 'int'},

This comment has been minimized.

@ngokevin

This comment has been minimized.

@fernandojsg

fernandojsg May 27, 2016

Member

yep, fixed. thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment