New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change sky radius back to 5000 #1585

Merged
merged 1 commit into from Jun 28, 2016

Conversation

Projects
None yet
2 participants
@ngokevin
Copy link
Member

ngokevin commented Jun 28, 2016

Description:

Doesn't actually affect the vertex/face number or degrade perf. Bigger number allows less distortion.

@dmarcos dmarcos merged commit 9ef27be into aframevr:master Jun 28, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

bryik added a commit to bryik/aframe-cubemap-component that referenced this pull request Jun 30, 2016

Change cubemap default edgeLength to 5000
At one point the default radius of A-Frame's sky primitive was changed
to 100 down from 5000. Performance was said to motivate this change.
However, recently this change was reverted and the default radius
brought back up to 5000.

Apparently sky radius "doesn't actually affect the vertex/face number or
degrade perf. Bigger number allows less distortion."
aframevr/aframe#1585

@bryik bryik referenced this pull request Jul 9, 2016

Merged

update docs 0.3.0 #1494

34 of 34 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment