change sky radius back to 5000#1585
Merged
dmarcos merged 1 commit intoaframevr:masterfrom Jun 28, 2016
Merged
Conversation
bryik
added a commit
to bryik/aframe-cubemap-component
that referenced
this pull request
Jun 30, 2016
At one point the default radius of A-Frame's sky primitive was changed to 100 down from 5000. Performance was said to motivate this change. However, recently this change was reverted and the default radius brought back up to 5000. Apparently sky radius "doesn't actually affect the vertex/face number or degrade perf. Bigger number allows less distortion." aframevr/aframe#1585
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Doesn't actually affect the vertex/face number or degrade perf. Bigger number allows less distortion.