New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gltf-model to glTF 2.0. #2986

Merged
merged 2 commits into from Aug 18, 2017

Conversation

Projects
None yet
2 participants
@donmccurdy
Member

donmccurdy commented Aug 18, 2017

Example assets bumped with aframevr/assets#27.

the glTF2.0 model is not backward-compatible, so users upgrading to A-Frame 0.7.0 but wanting to continue using their glTF1.0 assets will need to use gltf-model-legacy frome aframe-extras.

Fixes #2693.

@donmccurdy

This comment has been minimized.

Member

donmccurdy commented Aug 18, 2017

@donmccurdy

This comment has been minimized.

Member

donmccurdy commented Aug 18, 2017

Hm, in the interest of not breaking 0.6.0 examples, should the assets be added to a new folder, leaving the glTF 1.0 ones alone?

@dmarcos

This comment has been minimized.

Collaborator

dmarcos commented Aug 18, 2017

I think we won't break anything because the site won't deploy until 0.7.0. Am I right?

- [OBJ → glTF][obj-converter]
- [COLLADA → glTF][collada-converter]
- [glTF Workflow for A Saturday Night](https://blog.mozvr.com/a-saturday-night-gltf-workflow/)

This comment has been minimized.

@dmarcos

dmarcos Aug 18, 2017

Collaborator

Is the blog post still relevant? Is it worth to bring it up to date?

@dmarcos

This comment has been minimized.

Collaborator

dmarcos commented Aug 18, 2017

It looks good to me. I think merging this won't affect the current deployed examples on the site. I was wondering if the a-saturday-night blog post should be updated with a glTF2 workflow (https://blog.mozvr.com/a-saturday-night-gltf-workflow/) but we should first update the assets to glTF2. Maybe not worth now. Should we keep the link then? Is it the info in the blog post still relevant?

@dmarcos dmarcos merged commit ab36fe8 into aframevr:master Aug 18, 2017

3 checks passed

codecov/patch 100% of diff hit (target 1%)
Details
codecov/project 88.35% (target 70%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dmarcos

This comment has been minimized.

Collaborator

dmarcos commented Aug 18, 2017

Thank you very much! This makes me ultra happy. 😄 🎉 🎈 🎆 🍾

@donmccurdy

This comment has been minimized.

Member

donmccurdy commented Aug 18, 2017

@dmarcos Yay! Regarding the a-saturday-night blog post, a lot of what's written there is explaining how to work around limitations in the old Blender exporter, by exporting to COLLADA first. The new Blender exporter is much more reliable, and COLLDA2GLTF's glTF2.0 support is not finished, so I think we want to recommend using the Blender Exporter directly these days.

My vote would be to write a shorter new blog post, and then put an UPDATE: ... at the top of the old one linking to that. Unfortunately it's unlikely I would have time to write that in the next couple weeks. 😕

@donmccurdy donmccurdy deleted the donmccurdy:feat-gltf2 branch Aug 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment