flipped the sign on sampleUV.x in the Portal shader used by the link … #3079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
|
Congrats on your first PR! |
|
Thanks @machenmusik When do minor bug fixes show up in the main release? |
|
The fix will ship in A-Frame |
|
Cool. Thanks. |
|
Just FYI, @dmarcos is right, but if you don't want all the other changes that will happen in master, it is safer to use your specific commit rather than latest master. |
Kalkut
pushed a commit
to Kalkut/aframe
that referenced
this pull request
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link Component
Fix for issue 3077 #3077
Flipped the sign on sampleUV.x in the Portal shader that is used by the link component.