Model > One Variable > Fit Model dialog produced script

[Patowhiz]

The script produced by the dialog has redundant R code. think some of the lines of code can be omitted.

# Code generated by the dialog, One Variable Fit Model

tmax <- data_book$get_columns_from_data(data_name="dodoma", col_names="tmax")
last_model <- fitdistrplus::fitdist(data=as.vector(x=stats::na.exclude(object=tmax)), method="mle", distr="norm")
data_book$add_model(model_name="last_model", model=last_model, data_name="dodoma")
data_book$get_models(data_name="dodoma", model_name="last_model")
last_graph <- graphics::plot(x=data_book$get_models(data_name="dodoma", model_name="last_model"))
data_book$add_graph(graph_name="last_graph", graph=last_graph, data_name="dodoma")
data_book$get_graphs(data_name="dodoma", graph_name="last_graph")
rm(list=c("last_model", "tmax", "last_graph"))

I think line

 data_book$get_models(data_name="dodoma", model_name="last_model")
data_book$get_graphs(data_name="dodoma", graph_name="last_graph")

could be unnecessary.

[Patowhiz]

@Ivanluv I've been told by @rdstern you are looking into enhancing the dialog, probably you can have a look at what's causing this redundant scripts to be produced.

[Ivanluv]

Yeah, I am to make improvements to the dialogue .I will fix this when making the improvements.However, I cant work on this now since PR#5861 has changes on the same dialogue

[rdstern]

That's right. We need to wait for #5861 to be merged first.

[Ivanluv]

@Patowhiz I have just tried looking at this and the last line, data_book$get_graphs(data_name="dodoma", graph_name="last_graph") seems to be needed for the graph to be displayed

[Patowhiz]

@Ivanluv okay, what about line data_book$get_models(data_name="dodoma", model_name="last_model") ?

[Ivanluv]

@Patowhiz data_book$get_models(data_name="dodoma", model_name="last_model") is used to print the results in the output ie

Fitting of the distribution ' norm ' by maximum likelihood 
Parameters:
     estimate Std. Error
mean    4.486     0.5184
sd      3.110     0.3665

Also data_book$get_graphs(data_name="dodoma", graph_name="last_graph") is used by all the plots, apart from the multiplot, to displaying the graphs in the output window

[Patowhiz]

@Ivanluv thanks for the feedback, as discussed in you can take advantage of the newly added record_graph() function once PR #6060 is merged.

[Ivanluv]

@Patowhiz I don't think its necessary to use record_graph() function here because the graphs are saved in this dialogue

[Ivanluv]

@Patowhiz I don't think its necessary to use record_graph() function here because the graphs are saved in this dialogue

@Patowhiz what is your opinion

[shadrackkibet]

@Ivanluv could you check if there is anything we should address here otherwise we can close?

[Ivanluv]

@shadrack from my end ,I don't think there's anything to be addressed