Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace form.Hide with form.Close in order to work on Linux #6954

Merged
merged 1 commit into from Nov 29, 2021

Conversation

ChrisMarsh82
Copy link
Contributor

Updated all form.Hide to form.Close

@shadrackkibet can you check this doesn't break any functionality. I have checked areas that I've changed and the forms close and reload correctly however I'm not confident on all functionality

@dannyparsons
Copy link
Contributor

As long as the dialogs can still reopen in their previous state this should be fine.

@shadrackkibet The only other thing I can think of to check is dialogs where we set a default before opening it e.g. Levels/Labels from the grid right click menu. I think we can still set properties, because it works before the dialog has ever been opened - but good to check this.

I can't think of any other potential functionality issue.

@dannyparsons dannyparsons merged commit df767ce into IDEMSInternational:master Nov 29, 2021
@dannyparsons dannyparsons changed the title Replace form.Hide with from.Close in order to work on Linux Replace form.Hide with form.Close in order to work on Linux Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants