New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added recode options into recode numeric dialog #7136
Added recode options into recode numeric dialog #7136
Conversation
@mmulahvictor I added 'Fixes #6851' to your comment above. If I misunderstood, then please remove this text, thanks. @rdstern @shadrackkibet This PR replaces PR #6857 which @rdstern approved, and I think @shadrackkibet just required the merge conflict to be resolved. Please could you test/review again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmulahvictor sorry to be pedantic. The default is now, correctly 4.
But if you use the third option forst, and then come back to the dialogue, and then move to the first option - it is set to 1 again as the default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now and an excellent improvement on the previous dialogue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done @mmulahvictor.
Fixes #6851
This PR replaces #6857.
@africanmathsinitiative/developers @shadrackkibet
This is ready for review