Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevented user-entered text from being translated (e.g. to French) in File Import and Rename Columns dialogs #7591

Merged

Conversation

N-thony
Copy link
Collaborator

@N-thony N-thony commented Jul 5, 2022

Fixes #7590
Fixes #7615
@lloyddewit I made the following change in the database, I will add more if you agree with my suggestions in the corresponding issue.
image
image

@lloyddewit
Copy link
Contributor

@N-thony great! yes, please go ahead and make the other database changes (I added a comment to issue #7590 )

@N-thony
Copy link
Collaborator Author

N-thony commented Jul 8, 2022

@lloyddewit this is an example with input text control, I'm trying to tidying the Gambia dataset but in the frecnh version, I noticed the Nouveau nom input text control is translating automatically.
image

@lloyddewit
Copy link
Contributor

@lloyddewit this is an example with input text control, I'm trying to tidying the Gambia dataset but in the frecnh version, I noticed the Nouveau nom input text control is translating automatically.

@N-thony Thank you for the discussion on 06 July and the example above. I agree that the contents of this text box should not be translated. As discussed, is it possible to fix this in a generalized way so that the contents of text boxes is never translated?
Thanks

@N-thony
Copy link
Collaborator Author

N-thony commented Jul 10, 2022

@lloyddewit this is an example with input text control, I'm trying to tidying the Gambia dataset but in the french version, I noticed the Nouveau nom input text control is translating automatically.

@N-thony Thank you for the discussion on 06 July and the example above. I agree that the contents of this text box should not be translated. As discussed, is it possible to fix this in a generalized way so that the contents of text boxes is never translated? Thanks

We can simply set DoNotTranslate in the database to controls through their names that are susceptible to create an enumeration parameter.

@N-thony
Copy link
Collaborator Author

N-thony commented Jul 17, 2022

@lloyddewit this is an example with input text control, I'm trying to tidying the Gambia dataset but in the french version, I noticed the Nouveau nom input text control is translating automatically.

@N-thony Thank you for the discussion on 06 July and the example above. I agree that the contents of this text box should not be translated. As discussed, is it possible to fix this in a generalized way so that the contents of text boxes is never translated? Thanks

We can simply set DoNotTranslate in the database to controls through their names that are susceptible to create an enumeration parameter.

@lloyddewit we can merge this for instance, I'm afraid now to make this change, on the second thought it will be good to decide what to do once we got the requested data for preparing the workshop from DRC Met. I think that will help on how to make the change because the translation is done also by switching the languages, if during the workshop it will require us to switch sometime @rdstern then we should be very carefull with some input text control. I'm following up with the DRC Met at least by next week if we can have the sample of data requested.

@lloyddewit lloyddewit changed the title Fixed bug due to Translation in the import of CSV file Prevented user-entered text from being translated (e.g. to french) in File Import and Rename Columns dialogs Jul 17, 2022
@lloyddewit lloyddewit added the bug label Jul 17, 2022
@lloyddewit lloyddewit changed the title Prevented user-entered text from being translated (e.g. to french) in File Import and Rename Columns dialogs Prevented user-entered text from being translated (e.g. to French) in File Import and Rename Columns dialogs Jul 17, 2022
@lloyddewit lloyddewit merged commit 807662f into IDEMSInternational:master Jul 17, 2022
@lloyddewit
Copy link
Contributor

I merged this without asking @rdstern for test/approval because it is a low-risk database change and I thought a quick merge was more important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants