Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in Climatic Summary dialog #7715

Merged
merged 4 commits into from Nov 22, 2022

Conversation

Fidel365
Copy link
Contributor

@Fidel365 Fidel365 commented Aug 2, 2022

Fixes #7670
@N-thony , this PR is ready for preview

@N-thony
Copy link
Collaborator

N-thony commented Aug 3, 2022

Fixes #7670 @N-thony , this PR is ready for preview

@Fidel365 can you imporve the title of this PR more clear. When you say minor change it is not clear what this PR seeks to address.

@Fidel365
Copy link
Contributor Author

Fidel365 commented Aug 3, 2022

@N-thony , It did not see it's relevance there

@N-thony
Copy link
Collaborator

N-thony commented Aug 3, 2022

@N-thony , It did not see it's relevance there

it is needed to give a user an idea from the selector which type of variable is expected to the corresponding receiver.
So, I suggest that you put it back.

@Fidel365
Copy link
Contributor Author

Fidel365 commented Aug 3, 2022

@N-thony , this PR is ready for re-review

@EstherNjeriLiberatta
Copy link
Contributor

Fixes #7670 @N-thony , this PR is ready for preview

@Fidel365 can you improve the title of this PR to make it more clear? When you say minor change it is not clear what this PR seeks to address.

@Fidel365 Please make your title clearer as addressed by @N-thony. Which dialogue is this and what minor changes have you made? It's important especially to avoid working on similar dialogs. Thank you.

@N-thony
Copy link
Collaborator

N-thony commented Aug 12, 2022

@N-thony , this PR is ready for re-review

@Fidel365 did you resolve my comment above?

@Fidel365 Fidel365 changed the title minor change Fixes Bug in Climatic Summary Dialogue Aug 12, 2022
@Fidel365
Copy link
Contributor Author

@N-thony , I have changed the title of this PR

@Fidel365
Copy link
Contributor Author

@N-thony , can you review this?

rdstern
rdstern previously approved these changes Nov 20, 2022
Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@N-thony from my point of view this seems fine now. If the code is ok, then perhaps @lloyddewit could merge this.

instat/dlgClimaticSummary.vb Outdated Show resolved Hide resolved
@lloyddewit lloyddewit changed the title Fixes Bug in Climatic Summary Dialogue Fixed bug in Climatic Summary dialog Nov 22, 2022
@lloyddewit lloyddewit added the bug label Nov 22, 2022
@lloyddewit lloyddewit merged commit 74f9e9c into IDEMSInternational:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor bug in the Climatic Summary Dialogue
5 participants