Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more keys to the Prepare > Calculator > Transform Keyboard #7954

Merged
merged 5 commits into from Nov 15, 2022
Merged

Added more keys to the Prepare > Calculator > Transform Keyboard #7954

merged 5 commits into from Nov 15, 2022

Conversation

anastasia-mbithe
Copy link
Contributor

@anastasia-mbithe anastasia-mbithe commented Nov 7, 2022 •
edited

Fixes #7944 and also Fixes #7876

I have included the change that was requested under PR #7949.
@rdstern This is ready for testing.

@anastasia-mbithe anastasia-mbithe changed the title Added two keys to the Prepare > Calculator > Transform Keyboard. Added more keys to the Prepare > Calculator > Transform Keyboard. Nov 7, 2022
@anastasia-mbithe anastasia-mbithe mentioned this pull request Nov 7, 2022
Closed
rdstern
rdstern previously approved these changes Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anastasia-mbithe that's great - thanks

@anastasia-mbithe
Copy link
Contributor Author

@rdstern, since this is still open, I've added the suggested changes to the integer keyboard from issue #7876, so that we can close the issue as well.
Kindly have a look.

rdstern
rdstern approved these changes Nov 10, 2022
View reviewed changes
Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anastasia-mbithe that's great

@lloyddewit lloyddewit changed the title Added more keys to the Prepare > Calculator > Transform Keyboard. Added more keys to the Prepare > Calculator > Transform Keyboard Nov 15, 2022
@lloyddewit lloyddewit merged commit 73d6609 into IDEMSInternational:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdstern rdstern rdstern approved these changes

@lloyddewit lloyddewit lloyddewit approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
3 participants
@anastasia-mbithe @rdstern @lloyddewit