Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Complex Numbers keyboard to Calculator #8026

Merged
merged 6 commits into from Dec 22, 2022

Conversation

derekagorhom
Copy link
Contributor

@derekagorhom derekagorhom commented Dec 20, 2022

fixes (partially) #8013

This PR is ready for review

@derekagorhom
Copy link
Contributor Author

I wanted to find out if this keyboard would have tooltips and also i found out that some keyboards on the calculator do not have tooltips

Maths keyboard
trunc, deg, sign, abs, exp, logit, logistic, atan2

Text/String keyboard
reverse

@rdstern
Copy link
Collaborator

rdstern commented Dec 21, 2022

@derekagorhom this is excellent and I am also really pleased that you are questioning more broadly - with your question on tooltips. (That is for later.)
As far as I have tested, it is working fine, so could be merged. But I suggest some minor changes, plus then (sorry) some more keys. It has become more important than I thought earlier.
a) Could you make complex as the second-to-last keyboard. I really like keeping the Integer keyboard as the last one.
b) In the Help it goes to Base R correctly. Even though there is really only that one package, could you use the drop-down control. Then users can see the name of the package - call it just Base, without necessarily going into it.
c) Now the extra keys! Most are copies from the maths keyboard, but there are 3 new ones. I am not sure why they are not also on the maths keyboard, but that is for another time!
I now wonder about this layout:

complex, real, imaginary, rad
mod, arg, conjugate, deg
exp, sin, cos, tan
log, sinh, cosh, tanh
sqrt, round, signif, pi

@derekagorhom
Copy link
Contributor Author

@rdstern i have made the changes, can you review them
thanks

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derekagorhom I am impressed. To me it is all ok.

@lloyddewit lloyddewit changed the title Added Complex Numbers keyboard on calculator Added Complex Numbers keyboard to Calculator Dec 22, 2022
@lloyddewit lloyddewit merged commit fcf5cbf into IDEMSInternational:master Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants