Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add article for day 15 about Jane #209

Merged
merged 1 commit into from Dec 13, 2019
Merged

Add article for day 15 about Jane #209

merged 1 commit into from Dec 13, 2019

Conversation

@franek
Copy link
Contributor

franek commented Dec 9, 2019

Proposition d'article pour le 15 décembre à propos de Jane.

Vos relectures sont les bienvenus. Merciii.

Preview: https://afsy.fr.pr-209-6pviqdq-esyx3y2kpl5ku.eu.s5y.io/avent/2019

@Korbeil
Korbeil approved these changes Dec 9, 2019
@franek franek force-pushed the franek:day-15 branch from bd85a57 to 72e00f2 Dec 11, 2019
Copy link
Member

Nek- left a comment

Article concis mais très clair ! ;) Merci

Si tu souhaites le faire merger rapidement c'est possible. (il faudra le rebase)

Dit moi quand c'est bon pour toi !

templates/Avent/2019/day_15.html.twig Outdated Show resolved Hide resolved
templates/Avent/2019/day_15.html.twig Outdated Show resolved Hide resolved
templates/Avent/2019/day_15.html.twig Outdated Show resolved Hide resolved
templates/Avent/2019/day_15.html.twig Outdated Show resolved Hide resolved
templates/Avent/2019/day_15.html.twig Outdated Show resolved Hide resolved
@franek franek force-pushed the franek:day-15 branch 2 times, most recently from c3fda39 to 7a961bc Dec 13, 2019
@franek

This comment has been minimized.

Copy link
Contributor Author

franek commented Dec 13, 2019

J'ai rebase et squash.

merci @Nek- pour la review. J'ai lancé un dernier appel auprès de mes collègues. Si pas de retour d'ici la fin de la journée, tu peux merger ;)

@franek franek force-pushed the franek:day-15 branch from 7a961bc to bcadf4c Dec 13, 2019
@pyrech
pyrech approved these changes Dec 13, 2019
@Nek- Nek- merged commit 54d243c into afsy:master Dec 13, 2019
3 checks passed
3 checks passed
phpunit
Details
behat
Details
symfony SymfonyCloud: Environment deployed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.